Last modified: 2012-10-04 23:45:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42484, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40484 - CentralNotice unit tests broken
CentralNotice unit tests broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-24 20:16 UTC by Niklas Laxström
Modified: 2012-10-04 23:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2012-09-24 20:16:15 UTC 
Fatal error: Call to a member function addCampaign() on a non-object in /www/dev.translatewiki.net/w/extensions/CentralNotice/tests/CentralNoticeTest.php on line 38
Comment 1 Sam Reed (reedy) 2012-09-24 21:00:43 UTC 
Fairly obvious if you look at the code, self::$centralNoticeDB doesn't get anything assigned to it
Comment 2 Sam Reed (reedy) 2012-09-24 21:01:16 UTC 
And while someone ins in there...

There are to @todo FIXMEs needing passing of a user parameter
Comment 3 Nischay Nahata 2012-10-04 19:44:33 UTC 
here's a patchset https://gerrit.wikimedia.org/r/#/c/26663/
Comment 4 Matt Walker 2012-10-04 23:45:48 UTC 
Patch merged - the tests still fail - but at least they don't crash!

Thanks Nischay for making that change. :)

Next up: updating the tests so that they test the new architecture! Anyone? :p I'll get around to it eventually but certainly no one should wait for me.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links