Last modified: 2012-10-02 23:25:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42498, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40498 - ResourceLoader should not output an empty "@media print { }" block.
ResourceLoader should not output an empty "@media print { }" block.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Low enhancement (vote)
: 1.20.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-25 03:08 UTC by Krinkle
Modified: 2012-10-02 23:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-09-25 03:08:00 UTC
On a wiki with only MediaWiki:Common.css and Mediawiki:Vector.css (or rather, no MediaWiki:Print.css) the following request:

/mw/load.php?debug=false&lang=en&modules=site&only=styles&skin=vector&*

outputs:
> ...common....vector... @media print{ }
Comment 1 Krinkle 2012-09-25 03:08:40 UTC
Apparently already fixed in my rl-refactor branch, will push soon and reference this bug.
Comment 2 Krinkle 2012-09-25 17:15:25 UTC
Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.
Comment 3 Mark A. Hershberger 2012-09-28 21:55:39 UTC
Merge?
Comment 4 Mark A. Hershberger 2012-09-30 16:23:21 UTC
I'll make a merge request for 1.20
Comment 5 Krinkle 2012-10-02 23:25:07 UTC
(In reply to comment #2)
> Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.

Landed in master, and merged to REL1_20.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links