Last modified: 2012-10-02 23:25:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42500, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40500 - ResourceLoader should not ignore media-type for urls in debug mode
ResourceLoader should not ignore media-type for urls in debug mode
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: Normal normal (vote)
: 1.20.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-25 05:36 UTC by Krinkle
Modified: 2012-10-02 23:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2012-09-25 05:36:04 UTC 
Steps to reproduce:

* Go to: https://www.mediawiki.org/
* Let page load, open console
* Execute: `mw.loader.load('skins.modern')`

Expected result:

* Two <link> tags are added. main.css and print.css. print.css should not be active (in order words, media=print)

Actual result:

* Both are added without a media type.

This is actually quite easy to fix. Though we no longer support media-type for minified css strings (which is fine because we wrap them in @media on the server side), we have to support it still for urls.
Comment 1 Krinkle 2012-09-25 05:36:25 UTC 
Will be fixed in  my rl-refactor branch. Pushing soon with reference to this bug.
Comment 2 Krinkle 2012-09-25 17:15:30 UTC 
Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.
Comment 3 Mark A. Hershberger 2012-09-30 16:24:16 UTC 
Merge request tbd for 1.20
Comment 4 Mark A. Hershberger 2012-10-02 14:14:09 UTC 
See Gerrit I3c76e9a8
Comment 5 Krinkle 2012-10-02 18:38:01 UTC 
(In reply to comment #4)
> See Gerrit I3c76e9a8

No, the change id was already posted it is:

(In reply to comment #2)
> Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.
Comment 6 Krinkle 2012-10-02 23:25:24 UTC 
(In reply to comment #2)
> Fix in I3e8227ddb87fd9441071ca935439fc6467751dab.

Landed in master, and merged to REL1_20.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links