Last modified: 2013-02-07 08:26:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42576, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40576 - Add user contribution links to existing user conflicts
Add user contribution links to existing user conflicts
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AntiSpoof (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-27 18:07 UTC by Steven Walling
Modified: 2013-02-07 08:26 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Error screenshot (297.24 KB, image/png)
2012-09-27 18:07 UTC, Steven Walling
Details

Description Steven Walling 2012-09-27 18:07:15 UTC
Created attachment 11144 [details]
Error screenshot

See the attached file. 

It looks like there is some error output which is broken. When you attempt to create a username that is too close to an existing username (e.g. one character different) the error shows the associated user and links to their contribs. The contributions link is currently broken.
Comment 1 Sam Reed (reedy) 2012-09-27 18:13:31 UTC
'antispoof-conflict-top'  => 'The name "$1" is too similar to {{PLURAL:$2|the existing account|the following $2 accounts}}:',

$message = wfMessage( 'antispoof-conflict-top', $name )->numParams( $numConflicts )->escaped();


I'm guessing the message functions are called wrongly..

Siebrands fault from https://gerrit.wikimedia.org/r/#/c/22363/
Comment 2 Sam Reed (reedy) 2012-09-27 18:18:08 UTC
Errr, I retract that, slightly.

'antispoof-conflict-item' => '$1', # do not translate or duplicate this message to other languages

$message .= '<ul>';
foreach ( $conflicts as $simUser ) {
	$message .= '<li>' . wfMessage( 'antispoof-conflict-item', $simUser )->escaped() . '</li>';
}

Mix of Siebrands change, and the enwiki customisation of said message

https://en.wikipedia.org/w/index.php?title=MediaWiki:Antispoof-conflict-item&action=edit

$1 (<a href="/w/index.php?title=Special:Contributions&target=$1">contribs</a>)

'antispoof-conflict-item' => '$1', # do not translate or duplicate this message to other languages

Probably makes most sense to fix this message upstream, and change the code to support the desired output. Maybe.
Comment 3 Sam Reed (reedy) 2012-09-27 19:09:37 UTC
$message .= '<li>' . wfMsg( 'antispoof-conflict-item
', $simUser ) . '</li>';
$message .= '<li>' . wfMessage( 'antispoof-conflict-
item', $simUser )->escaped() . '</li>';


Technically, this isn't actually a bug... And should probably be swapped to a feature request to have the contribution links...
Comment 4 Steven Walling 2012-09-27 19:17:11 UTC
(In reply to comment #3)
> $message .= '<li>' . wfMsg( 'antispoof-conflict-item
> ', $simUser ) . '</li>';
> $message .= '<li>' . wfMessage( 'antispoof-conflict-
> item', $simUser )->escaped() . '</li>';
> 
> 
> Technically, this isn't actually a bug... And should probably be swapped to a
> feature request to have the contribution links...

IMO, I don't think the contribution links provide clear value. The message just needs to tell the user that a similar name already exists, not tell them what the person has done.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links