Last modified: 2013-11-12 15:20:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42594, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40594 - Get rid of Wikipedia-Specific code
Get rid of Wikipedia-Specific code
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-28 12:32 UTC by Daniel Kinzler
Modified: 2013-11-12 15:20 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2012-09-28 12:32:05 UTC
Find and remove any wikipedia specific logic hardcoded in wikibase.

Tim mentioned several here: https://bugzilla.wikimedia.org/show_bug.cgi?id=38822#c7

Full quote:

In ItemView.php:

/**
 * Returns a list of all the sites that can be used as a target for a site
link.
 *
 * @static
 * @return array
 */
public static function getSiteDetails() {
...
    if ( $site->getType() === Site::TYPE_MEDIAWIKI && $site->getGroup() ===
'wikipedia' ) {

The autocomplete feature that this function services also references Wikipedia
in a message (wikibase-error-autocomplete-connection). 

There doesn't seem to be any way to populate the sites table with data other
than the data that comes from meta.wikimedia.org, I had to patch
Utils::insertDefaultSites() to set up my test instance.

populateInterwiki.php also unconditionally references Wikipedia.
Comment 1 Lydia Pintscher 2013-10-19 17:20:20 UTC
Can we identify what's still missing here to start splitting this into manageable tasks?
Comment 2 Daniel Kinzler 2013-10-29 11:05:50 UTC
As far as I know, we fixed all of these issues when adding support for wikivoyage and commons.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links