Last modified: 2013-03-17 19:51:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42595, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40595 - AFTv5 controls not selectable with tab
AFTv5 controls not selectable with tab
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Matthias Mullie
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-28 16:23 UTC by the wub
Modified: 2013-03-17 19:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description the wub 2012-09-28 16:23:24 UTC
When "Help improve this page" appears at the bottom of a page, neither the "What's this?" link nor the "Yes" and "No" buttons are selectable using the Tab key. This is an accessibility issue.

(After clicking Yes or No, the controls which then appear are selectable.)
Comment 1 Rodan BURY 2012-09-28 22:07:00 UTC
I'm from the accessibility project. Yes, this is an accessibility issue. People with severe motor impairments may only use a limited amount of keyboard keys, or only the tab key, to interact with websites.

The code used in this feedback tool is complicated, and it is beyond my knowledge to find where the precise problems lies.

However, I have written a guide that explains where the issues might be, and how to fix them. It should be easy and straightforward for a seasoned developer.

http://en.wikipedia.org/wiki/Wikipedia:WikiProject_Accessibility/MediaWiki_accessibility_specification#Keyboard_Navigation

In short, the issue might lie with the HTML elements used for the interactive components. Using elements meant for interaction should solve this problem (A, BUTTON, and such). The second possibility is related to mouse event handlers: adding a redundant keyboard event handler solves the issue.

Cheers, Rodan Bury
Comment 2 Matthias Mullie 2012-12-03 11:58:25 UTC
https://gerrit.wikimedia.org/r/#/c/36537/ will fix this
Comment 3 Andre Klapper 2013-02-18 13:09:36 UTC
In the "Help improve this page" on http://ee-prototype.wmflabs.org/wiki/Main_Page (AFTv5 b2edc4f ), I can access the "Yes" and "No" buttons via the tab key in Firefox 18.0.2 now that https://gerrit.wikimedia.org/r/#/c/36537/ got merged.

I still cannot access the "What's this?" link.
Comment 4 Matthias Mullie 2013-02-19 16:31:57 UTC
After https://gerrit.wikimedia.org/r/#/c/49835/ is deployed, you should now also be able to access the "What's this?" link :)
Comment 5 Alex Monk 2013-03-17 19:51:13 UTC
Merged by Kaldari on the 14th.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links