Last modified: 2013-04-22 16:17:18 UTC
Because of the borders and the way floats are treated, the editing textarea and toolbars when using Extension:WikiEditor are slightly wider than they should be, causing them to overflow out of the bodyContent by 2px. Removing the border from the .wikiEditor-ui div and applying it instead to a non-floating container div as follows should resolve this: <div class="wikiEditor-ui-container" style="border: 1px solid #c0c0c0;"> <div class="wikiEditor-ui"> ... </div> <div style="clear: both;"></div> </div> .wikiEditor-ui { border: none; } .wikiEditor-ui-container { border: 1px solid #c0c0c0; }
A somewhat simpler solution has been thingied to thingies pending thinging on/in/en... git thing. This: https://gerrit.wikimedia.org/r/28664 ...shut up.
Adding patch-in-gerrit keyword.
I think this should be fixed with bug 40610 and commit https://gerrit.wikimedia.org/r/28665
That fix doesnt work in IE 8 or lower. Id comment on gerrit but I cannot figure out how.
Oh, and that fix is just for editing textarea; wikieditor has a different problem.
You mean IE6 and IE7. IE8 supports box-sizing fine. http://caniuse.com/css3-boxsizing
(In reply to comment #6) > You mean IE6 and IE7. IE8 supports box-sizing fine. > > http://caniuse.com/css3-boxsizing That website is wrong. IE8 does not support it by default; if you can, try it.
While https://gerrit.wikimedia.org/r/28665 is merged, https://gerrit.wikimedia.org/r/28664 isn't, plus this still applies to non-IE browsers according to Isarra on IRC< hence reverting my summary change.
Yeah, this one needs the extension fix. Said fixes don't apply to most versions of IE8-, but the issue is cross-browser.
Bug assigned to code submitter.
Resetting assignee for now. Isarra should not be responsible for this bug. The patch is welcome but someone else needs to review it and be responsible for possible future updates on this bug.
(In reply to comment #11) > Resetting assignee for now. Isarra should not be responsible for this bug. The > patch is welcome but someone else needs to review it and be responsible for > possible future updates on this bug. Perhaps I'm misunderstanding, but that wording makes it seem like you are saying that you are doing that because of some problem with me as well as with the change that has been submitted. Is this the case, and if so, what is the issue? I would very much like to see this bug resolved.
(In reply to comment #12) > (In reply to comment #11) > > Resetting assignee for now. Isarra should not be responsible for this bug. The > > patch is welcome but someone else needs to review it and be responsible for > > possible future updates on this bug. > > Perhaps I'm misunderstanding, but that wording makes it seem like you are > saying that you are doing that because of some problem with me as well as with > the change that has been submitted. Is this the case, and if so, what is the > issue? I would very much like to see this bug resolved. Hi Isarra. Sorry, that message is rather out of context for you. Nothing changed really. Let me explain :) 2 hours ago the bug didn't have an assignee and you took the time to contribute a patch. Awesome! Then Dereckson set the bug assignee to your Bugzilla account and then I undid that last action. That's all. I haven't personally reviewed your patch (yet), but as far as I'm concerned it's fine and it'll get merged and deployed within a few hours/days. We usually don't assign bugs directly to a patch contributor unless they are a (whether or not staff) maintainer of the extension. Because to be assigned means you see after the bug (to fix it by writing or reviewing a patch, merging it, closing the bug afterwards and potentially repeating this cycle in some distant future if the bug is re-opened) - which is a small duty but not obvious, which is why we usually don't assign contributors directly (unless the contributor is also a maintainer of the extension in which case he can fix it himself).
The patch was added almost a month ago. I would be very surprised if it gets merged this year. That said, thank you for the explanation.
(In reply to comment #14) > The patch was added almost a month ago. I would be very surprised if it gets > merged this year. > > That said, thank you for the explanation. Gerrit change #28664 was merged by Ori on the 14th. Is this fixed now?
At present it is merged, yes, but apparently not deployed anywhere I've seen. As far as we're concerned with this bug, however, the thing is resolved... right? Is that how it works?
(In reply to comment #16) > At present it is merged, yes, but apparently not deployed anywhere I've seen. > As far as we're concerned with this bug, however, the thing is resolved... > right? Is that how it works? You mean WMF hasn't updated their live copies to include the patch yet? Yeah, that doesn't matter. You can mark this bug resolved fixed now I think.
