Last modified: 2012-10-10 06:53:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42630, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40630 - Performance issue with Internet Explorer and Narayam
Performance issue with Internet Explorer and Narayam
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.21.x
All All
: Highest major (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript, performance, upstream
: 40890 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-29 23:06 UTC by Dhaval
Modified: 2012-10-10 06:53 UTC (History)
14 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dhaval 2012-09-29 23:06:17 UTC
for last couple of weeks (at least) gu.wikisource has become very slow in typing. The issue is specifically on IE9 and IE6, but on firefox, speed is normal. on ws, typing input is very slow everywhere, e.g. search input, page text box, edit summary, etc.

Tried disabling JS in IE9 and that brought back the speed to normal. <Dereckson> & <MatmaRex> tried some bits as well...
Comment 1 Dereckson 2012-09-29 23:49:00 UTC
[ adding 'javascript' keyword ]
Comment 2 Srikanth Logic 2012-10-01 06:15:08 UTC
Does it happen only when Narayam is enabled or even otherwise? There is a IE fix waiting to be deployed for Narayam.
Comment 3 Dereckson 2012-10-01 07:16:00 UTC
(In reply to comment #2)
> Does it happen only when Narayam is enabled or even otherwise? There is a IE
> fix waiting to be deployed for Narayam.
It has been tested with Narayam disabled (using the own script checkbox enable/disable). It doesn't affect the issue.
Comment 4 Srikanth Logic 2012-10-04 07:47:18 UTC
Heard a similar comment from IE8 user as well.
Comment 5 Kalaiarasy 2012-10-04 09:02:58 UTC
Yes, I'm having this problem for a couple of weeks in IE 8. It's very very slow to type anything in tamil wikipedia. The problem exists in ta.wiktionary too. And when I open new sites in ta.wiki, get a message 'wheather to stop the script running in wikipedia pages, otherwise, the IE runs slowly'. Though I clicked on 'yes' to stop the script, it works slowly. I tried clearing the cache, but it didn't help either.
Comment 6 Andre Klapper 2012-10-09 15:59:07 UTC
Bug 40890 might be related.
Comment 7 Andre Klapper 2012-10-09 16:17:37 UTC
(In reply to comment #2)
> There is a IE fix waiting to be deployed for Narayam.

Srikanth: Any link to Gerrit handy?
Comment 8 Sam Reed (reedy) 2012-10-09 16:22:31 UTC
(In reply to comment #6)
> Bug 40890 might be related.

I'd be pretty sure it is.


(In reply to comment #7)
> (In reply to comment #2)
> > There is a IE fix waiting to be deployed for Narayam.
> 
> Srikanth: Any link to Gerrit handy?

https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Narayam,n,z

^ I wouldn't say any of them are relevant...
Comment 9 Siebrand Mazeland 2012-10-09 16:34:04 UTC
Making highest priority for Santhosh.
Comment 10 Sam Reed (reedy) 2012-10-09 17:14:13 UTC
(In reply to comment #9)
> Making highest priority for Santhosh.

http://blog.jquery.com/2012/09/20/jquery-1-8-2-released/

^ Is that likely to help matters at all?

https://gerrit.wikimedia.org/r/#/c/27298/
Comment 11 Bartosz Dziewoński 2012-10-09 18:32:34 UTC
I doubt it, but there *is* something about "Performance degradation with delegate events and pseudo-classes" (#12436) in the changelog, which might just accidentally alleviated this issue as well. Needs to be tested.
Comment 12 Siebrand Mazeland 2012-10-09 19:30:23 UTC
*** Bug 40890 has been marked as a duplicate of this bug. ***
Comment 13 Siebrand Mazeland 2012-10-09 19:42:12 UTC
I'm using a mid 2010 MacBook Pro 2,66 GHz Intel Core i7 with Windows 7 with 2.4GB RAM and 2 cores assigned in VMWare 5.0.1.

I've tested with Windows 7 (nlNL local), fully patched, with IE9.0.812. 

Site visited: http://sandbox.translatewiki.net

This runs MediaWiki 1.21 alpha (master/HEAD) and the latest versions for extensions.

Logged in user, with setlang=de

Observations:
1. IME disabled in preferences: 4-5% CPU utilisation while editing* User:Siebrand
2. IME enabled in preferences, disabled in UI: 5-10% CPU utilisation while editing User:Siebrand
3. IME enabled in preferences, enabled in UI: 10-25% CPU utilisation while editing User:Siebrand

* "editing" is in this case random keystrokes in the edit screen. Example: sdfsdfa sdfawerfavs bvsd vsdfvsdfvsdfvsdfvsdfv. I have no noticeable performance degradation, but I can imagine that for slower/older hardware it is noticeable. What I notice is that while inputting text in scenarios 2 and 3, my notebook fan starts buzzing.

I'm going to pull in jQuery 1.8.2 from Gerrit change #27298 now, to see if that helps any. http://bugs.jquery.com/ticket/12436 was about "Performance degradation with delegate events and pseudo-classes".

More later.
Comment 14 Bartosz Dziewoński 2012-10-09 19:46:02 UTC
I could reproduce severe hanging on a Thinkpad T60 laptop (Intel Core2 2GHz, 2 GB RAM), IE 8, Windows XP SP3.
Comment 15 Dhaval 2012-10-09 20:21:41 UTC
(In reply to comment #13)
> performance degradation, but I can imagine that for slower/older hardware it is
> noticeable. What I notice is that while inputting text in scenarios 2 and 3, my
> notebook fan starts buzzing.
> 
> I'm going to pull in jQuery 1.8.2 from Gerrit change #27298 now, to see if that helps
> any. http://bugs.jquery.com/ticket/12436 was about "Performance degradation
> with delegate events and pseudo-classes".
> 
> More later.

I use HP Pavilion g series laptop, with Intel core i5 processor, 2.4 Ghz, 6.00 GB RAM, 64-bit, installed OS: Windows 7 Home premium SP 1. I face serious performance issue in operating wikisource only in my IE9. Wikipedia and wiktionary works perfectly OK. In my office, all the Gujarati wikis are facing the issue of slowness, where I have IE6 installed and OS is windows XP. Don't know processor but RAM is 2 GB.

So from my experience, it has definitely nothing to do with hardware as with 6 GB RAM and Intel i5 if it is slow, we must do something. This is not the first time that with mediawiki upgrade Gujarati wiki projects have suffered, couple of months back also we had issue after upgrade, see Bug 36275.
Comment 16 Siebrand Mazeland 2012-10-09 20:55:32 UTC
Update to comment 13: Using jQuery 1.8.2 doesn't appear to help much. I'd like to think that CPU usage has decreased by a few percent, but that's still not very significant. sandbox.translatewiki.net is now running jQuery 1.8.2 and I've just updated everything to HEAD of master again.

Good luck digging into this, Santhosh.
Comment 17 Bartosz Dziewoński 2012-10-09 21:20:33 UTC
(In reply to comment #16)
> Update to comment 13: Using jQuery 1.8.2 doesn't appear to help much.

Actually this appears to fix the issue for me. sandbox.translatewiki.net is smooth, I don't notice any slowness; about 5% processor usage (but this might be background processes and tabs). translatewiki.net is still unusable if Narayam is enabled; 100% usage and a few seconds of waiting every time I attempt typing.
Comment 18 Siebrand Mazeland 2012-10-09 21:28:23 UTC
(In reply to comment #17)
> (In reply to comment #16)
> > Update to comment 13: Using jQuery 1.8.2 doesn't appear to help much.
> 
> Actually this appears to fix the issue for me. sandbox.translatewiki.net is
> smooth, I don't notice any slowness; about 5% processor usage (but this might
> be background processes and tabs). translatewiki.net is still unusable if
> Narayam is enabled; 100% usage and a few seconds of waiting every time I
> attempt typing.

I'll update twn production, too. This is valuable info. Thanks for the feedback.

I think Krinkle is in charge of deciding which version of jQuery we will be using. Krinkle: what are the current plans, and should we consider backporting 1.8.2 to 1.20, too?
Comment 19 Sam Reed (reedy) 2012-10-09 21:29:58 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Update to comment 13: Using jQuery 1.8.2 doesn't appear to help much.
> > 
> > Actually this appears to fix the issue for me. sandbox.translatewiki.net is
> > smooth, I don't notice any slowness; about 5% processor usage (but this might
> > be background processes and tabs). translatewiki.net is still unusable if
> > Narayam is enabled; 100% usage and a few seconds of waiting every time I
> > attempt typing.
> 
> I'll update twn production, too. This is valuable info. Thanks for the
> feedback.
> 
> I think Krinkle is in charge of deciding which version of jQuery we will be
> using. Krinkle: what are the current plans, and should we consider backporting
> 1.8.2 to 1.20, too?


I'd be somewhat inclined to do so - it's a bugfix point release
Comment 20 Siebrand Mazeland 2012-10-09 21:51:48 UTC
FYI: translatewiki.net is now also on jQuery 1.8.2. Those effected, please test on https://translatewiki.net and let us know here what your test results are (see test plan in comment 13) and which hardware/software you are using if you still see issues.
Comment 21 Dhaval 2012-10-09 22:29:40 UTC
(In reply to comment #20)
> FYI: translatewiki.net is now also on jQuery 1.8.2. Those effected, please test
> on https://translatewiki.net and let us know here what your test results are
> (see test plan in comment 13) and which hardware/software you are using if you
> still see issues.

I tested translatewiki.net, and it works perfectly well. But not hadn't tested it earlier, so not sure whether the issue on gu:ws is related to it... can u plz. try reverting the same on there as well?
Comment 22 Siebrand Mazeland 2012-10-09 22:42:56 UTC
Sam/Reedy has just merged (Gerrit change #27369) and deployed[1] jQuery 1.8.2 on 1.21wmf1, which includes Wikimedia Commons and gu.wikisource. There may be some delay because of caching, but you can add "debug=true" as a CGI parameter to make sure you get the "current" JavaScript.

I'm closing this issue for now, because I think it's resolved. Santhosh will double check in a few hours if there's anything that should be optimized in Narayam.


[1] http://hexm.de/m4
Comment 23 Dhaval 2012-10-09 22:46:11 UTC
Superb...! GU:WS fixed now. Thank you all guys! will check on my office IE6/IE7, hope there won't be any issue there either... any changes made on GU:WP as well? as on older versions of IE its sluggish across the gu projects, I assume with all Narayam installed wikis
Comment 24 Sam Reed (reedy) 2012-10-09 23:25:55 UTC
(In reply to comment #23)
> Superb...! GU:WS fixed now. Thank you all guys! will check on my office
> IE6/IE7, hope there won't be any issue there either... any changes made on
> GU:WP as well? as on older versions of IE its sluggish across the gu projects,
> I assume with all Narayam installed wikis

Oh, they will be slow...

I've only backported it to 1.21wmf1 wikis (so all non wikipedia projects, plus enwiki). They are due for upgrade in around 18 hours. I'm not overly sure if it's worth backporting to 1.20wmf12 too. I can though if needed/wanted/requested
Comment 25 Sam Reed (reedy) 2012-10-09 23:31:22 UTC
Done anyway https://gerrit.wikimedia.org/r/27379
Comment 26 Siebrand Mazeland 2012-10-10 06:53:10 UTC
Some more info from Gerrit change #27388:

Remove the expensive event listeners

In every keydown, keypress, focus, blur on the document, Narayam
was triggering the jquery selectors - this is very expensive. This
was done to enable Narayam on future DOM elements. This is very rarey
used feature and its cost is high.

As of now, I am not aware of any usecase which use this. If we notice
such usecase we can add them in some UI context with narrow selector
scope.

Browsers like IE is very slow in executing jquery.on on selectors. See
Bug 40630. Eventhough it was solved by jquery upgrade, it is not good
to keep this feature in Narayam.

Change-Id: I7c382913179af913aafd7ecca4dbc18a988ec1f9

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links