Last modified: 2014-01-27 12:11:09 UTC
AntiSpoof_body.php has $deprecated = array_search( "SCRIPT_DEPRECTED", $testScripts ); I think the typo means usernames with characters in the ranges CJK Radicals Supplement, Kangxi Radicals, CJK Compatibility Ideographs, etc. will not be rejected. But I tried to add a failing test for this to SpoofTest.php and it passes, so I can't demonstrate the failure.
Created attachment 11152 [details] Changes to SpoofTest.php `git review` fails, maybe I don't have rights. Here's a patch that introduces testCheckBadChars() with some working tests, but the tests for SCRIPT_DEPRECATED glyphs doesn't work.
Gerrit change #25856 (if you need to get it and improve it, use gerrit -d 25856) ______________________ The first time you clone a repository, you can use git review -s to add git review and Gerrit specific hooks. One of them will add the last git Change-Id to the commit message. If you commit stuff before the git review -s, then launch git review, it will do that for you (Creating a git remote called "gerrit" that maps to: ssh://<your username>@gerrit.wikimedia.org:29418/mediawiki/extensions/AntiSpoof.git). But it won't edit your commit message, so Gerrit will reject it with this message: remote: ERROR: missing Change-Id in commit message It will even suggest you a commit message (your commit message + the Change-Id). (...) remote: Change-Id: I98e4bc5aa0034369910effda73625ce8b03288be What you have to do is: (1) copy/paste this line (without the remote: ) (2) git commit --amend (3) add this line to your commit message (4) git review
Patch in Gerrit needs an update.
Change 109464 had a related patch set uploaded by Arav93: Renamed SCRIPT_DEPRECTED to SCRIPT_DEPRECATED in Antispoof_body.php https://gerrit.wikimedia.org/r/109464
Change 109464 merged by jenkins-bot: Renamed SCRIPT_DEPRECTED to SCRIPT_DEPRECATED in Antispoof_body.php https://gerrit.wikimedia.org/r/109464
Should be fixed by the patch above.
