Last modified: 2014-01-21 03:32:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42666, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40666 - 'version-poweredby-others' message should not link to MediaWiki CREDITS file
'version-poweredby-others' message should not link to MediaWiki CREDITS file
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.20.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-01 19:11 UTC by Yaron Koren
Modified: 2014-01-21 03:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yaron Koren 2012-10-01 19:11:31 UTC 
I disagree with this change, from July:

https://gerrit.wikimedia.org/r/#/c/13558/

The message 'version-poweredby-others', which shows up when you add '...' to a list of authors in $wgExtensionCredits, was changed from just reading "others" (in English), to being a link to the MediaWiki CREDITS file. This makes sense for core MediaWiki, of course, but it doesn't make any sense for extensions - and many extensions use that '...' notation. I believe the change should be reverted, and the linking should instead be done in whatever code specifically handles the display of core MediaWiki credits in Special:Version.
Comment 1 Dereckson 2012-10-01 19:17:16 UTC 
[ Adding 'code-update-regression' keyword. ]
Comment 2 Dereckson 2012-10-01 19:17:46 UTC 
[ Adding Liagent as cc, as he's the change author. ]
Comment 3 Liangent 2012-10-01 19:34:08 UTC 
Huh it got merged?

I haven't touch it again for months,
Comment 4 Dereckson 2012-10-01 19:38:37 UTC 
Yes, according Gerrit history, it was merged by Hashar July 2nd.

Nikerabbit and Siebrand then recommended the same day to revert the change.

The discussion stopped there.
Comment 5 Yaron Koren 2014-01-21 02:49:26 UTC 
It looks like this was fixed just two days later:

https://gerrit.wikimedia.org/r/#/c/26468/

I should have checked earlier...
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links