Last modified: 2012-10-12 08:33:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42680, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40680 - Feedback page - 'Oversight requested' appears twice in 'More filters' drop down menu
Feedback page - 'Oversight requested' appears twice in 'More filters' drop do...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-01 23:38 UTC by Fabrice Florin
Modified: 2012-10-12 08:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Article-feedback-bug-oversight-requested-filter-appears-twice-in-dropdown-menu (278.47 KB, image/png)
2012-10-01 23:38 UTC, Fabrice Florin
Details

Description Fabrice Florin 2012-10-01 23:38:49 UTC
Created attachment 11154 [details]
Article-feedback-bug-oversight-requested-filter-appears-twice-in-dropdown-menu

In the Central feedback page, the 'More filters' drop down menu has two instances of 'Oversight requested', as shown in the attached screenshot.

There should only be one instance of this filter.
Comment 1 Matthias Mullie 2012-10-02 11:07:24 UTC
The first one (with the most entries) is visible only to oversighters and contains all posts that have been oversight-requested.
The second one is also visible to monitors and contains all posts that have been oversight-requested, but have not yet been oversighted.

Which should be removed? Personally, I don't think the first one makes a lot of sense, as these entries are all in the "oversighted" filter as well, and I don't really see how this additional filter for their origin ("they were requested for oversight") would matter.
I've removed the first one (Gerrit: https://gerrit.wikimedia.org/r/#/c/26032/, prototype as well), is that OK?
Comment 2 Fabrice Florin 2012-10-02 16:25:28 UTC
Thanks, Matthias.

I agree with your decision to keep the second filter, which should only show oversight requests which were neither oversighted NOR declined. On the Central feedback page right now, there are only 11 such posts.

(And it is appropriate to remove the first filter that includes all oversight requests -- including those that have been oversighted or declined - now over 200 items).

However, the second filter which you kept is not visible to people in the aft-hide group, which now lets me see oversighted items. Can we fix this, please?

Also, while you're working on this drop-down menu, it would be great if you could replace the bottom label 'All (oversight)' with 'All posts', to be more clear about the real effect of that action.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links