Last modified: 2012-10-12 20:42:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42682, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40682 - Gerrit: cherry-pick submit-records patch on our installation
Gerrit: cherry-pick submit-records patch on our installation
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Chad H.
:
Depends on:
Blocks: 40681
  Show dependency treegraph
 
Reported: 2012-10-02 00:02 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-10-12 20:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-10-02 00:02:32 UTC
The Zuul gateway between Gerrit and Jenkins requires a patch to be applied to Gerrit. It implements a method named `submit-records`:

"""
Show submit record information about the change, which includes whether the change has been or can be submitted, and whether each review label has had its criteria met.
"""

The patch has been made by OpenStack against Gerrit 2.4.2 in their fork:

https://review.openstack.org/#/c/10138/

It is being upstreamed against master at:

https://gerrit-review.googlesource.com/#/c/37930/

We would need to either:
- build our own 2.4.2, cherry-picking OpenStack patch
- build our own stable-2.5 snapshot, cherry-picking upstream patch
- get upstream patch to be included in 2.5
Comment 1 Antoine "hashar" Musso (WMF) 2012-10-02 00:03:23 UTC
Block bug 40681 - deploy Zuul
Comment 2 Antoine "hashar" Musso (WMF) 2012-10-11 20:01:10 UTC
Chad working on this. We chat daily about it.  We are heading toward building our own 2.4.2 hosted on operations/gerrit.git :

$ git lg origin/stable-2.4..wikimedia/stable-2.4-wmf
* ffe1a9a - (wikimedia/stable-2.4-wmf) Add submit records to query output (7 hours ago) <James E. Blair>
Comment 3 Chad H. 2012-10-11 20:17:18 UTC
Have built our 2.4.2: http://noc.wikimedia.org/~demon/gerrit-2.4.2-1-ga076b99.war

Tested on labs, planning to upgrade on production tomorrow.

Also, this has been pulled into 2.5 so upgrading won't lose the functionality :)
Comment 4 Chad H. 2012-10-12 20:42:17 UTC
Deployed this today.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links