Last modified: 2012-12-10 20:23:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42773, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40773 - VisualEditor: Save dialog "minor edit" link should either give a pop-up explanation or target=_new
VisualEditor: Save dialog "minor edit" link should either give a pop-up expla...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized minor
: VE-deploy-2012-12-10
Assigned To: Rob Moen
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-04 19:41 UTC by James Forrester
Modified: 2012-12-10 20:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2012-10-04 19:41:42 UTC 
Right now the "This is a [minor edit]" text in the save dialog tries to take the user to a new page in the current context, prompting them to abandon their changes (or not leave). This is sub-optimal. :-)
Comment 1 Rob Moen 2012-12-05 23:47:56 UTC 
Funny enough, in the current edit mode the minor edit link takes you away from editing.   AFAIK, the taget attribute cannot be added to a link wikitext.  Solution is to open the minor edit page in a new tab by setting target: _new with jQuery.

Patch in https://gerrit.wikimedia.org/r/37154
Comment 2 Rob Moen 2012-12-06 00:16:22 UTC 
Changed to target=_blank
Comment 3 Roan Kattouw 2012-12-06 01:48:33 UTC 
Merged.
Comment 4 James Forrester 2012-12-10 20:23:46 UTC 
Note which milestone this met.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links