Last modified: 2012-10-15 20:04:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42780, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 40780 - searchsuggest-containing line ("containing...") doesn't include the entered text
searchsuggest-containing line ("containing...") doesn't include the entered text
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Normal normal (vote)
: 1.20.x release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-04 22:02 UTC by Rob Lanphier
Modified: 2012-10-15 20:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rob Lanphier 2012-10-04 22:02:11 UTC 
When searching on 1.21wmf1 or later wikis, the bit in the search suggestions where it says "containing..." doesn't provide the text that's entered into the search box.

Repro:
1.  Enter search text "foo" on 1.21wmf1 wiki
2.  Read the suggestions area

Expected:  option which has "containing... foobar"
Actual: option which only has "containing..."

Possible cause: deployment of SimpleSearch (see bug 29374)
Comment 1 Krinkle 2012-10-04 23:55:47 UTC 
SimpleSearch has been deployed on wmf for over a year, we only changed mediawiki defaults recently.

Probably caused by a small error when SimpleSearch from ext.Vector was moved into core to replace legacy.mwsuggest.
Comment 2 Erik Moeller 2012-10-05 21:32:09 UTC 
This issue appears timing-dependent; with repeated reloads I can sometimes but not always reproduce in Chrome and FF on 1.12wmf1 wikis.

It would be good to get this fixed before further 1.21wmf1 deployments.
Comment 3 Krinkle 2012-10-10 02:26:16 UTC 
Caused by a number of small issues unrelated to mediawiki.searchSuggest, it just happend to trigger them in a combination exposing them this way.

Fix in I4649ec0c89d38c4d79d1dceec28227902cd48d32.
Comment 4 Derk-Jan Hartman 2012-10-15 20:04:36 UTC 
merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links