Last modified: 2012-12-31 15:21:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42805, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40805 - Title->getNamespaceKey() should handle talk pages
Title->getNamespaceKey() should handle talk pages
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-05 16:44 UTC by Bartosz Dziewoński
Modified: 2012-12-31 15:21 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2012-10-05 16:44:47 UTC
It only returns keys for content namespaces, even if called on a title in a talk namespace. This causes code duplication everywhere where the distinction is necessary, as well as interop issues – e.g. SkinTemplate has it's own way of converting these keys to talk keys, and it has to be faithfully replicated in skins that need to even slightly mangle the navigation links.

(Or maybe a different function should be introduced, to keep backwards compatibility? It appears to be used in a few extensions and extension-skins, including LiquidThread; I didn't check if these actually depend on current behavior.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links