Last modified: 2013-04-22 16:15:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42860, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 40860 - Maintenance::purgeRedundantText() fails on old archived revisions


Summary:	Maintenance::purgeRedundantText() fails on old archived revisions

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Maintenance scripts (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-10-08 14:41 UTC by Dévai Tamás
Modified:	2013-04-22 16:15 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Handle NULL values in `archive`.`ar_text_id` (613 bytes, patch) 2012-10-08 14:41 UTC, Dévai Tamás	Details
Add an attachment (proposed patch, testcase, etc.)

Description Dévai Tamás 2012-10-08 14:41:54 UTC

Created attachment 11159 [details]
Handle NULL values in `archive`.`ar_text_id`

If the `ar_text` field contains the text of the archived revision in the `archive` table, the `ar_text_id` field is NULL. Scanning a database with such fields will insert a NULL value to the set of text IDs, which renders the generated SQL query invalid.

Attached is a patch with a possible solution.

Comment 1 Sumana Harihareswara 2012-10-11 13:04:22 UTC

Thanks for the patch, Dévai Tamás! I'm trying to get someone to take a look at this patch soon.

If you get developer access

https://www.mediawiki.org/wiki/Developer_access

you can submit these kinds of changes right into our source control system!  Take a look.

Comment 2 Andre Klapper 2013-01-14 21:46:20 UTC

Hi Dévai, did you have time and interest to check out Wikimedia Developer Access?

Comment 3 Bawolff (Brian Wolff) 2013-01-15 17:17:06 UTC

Hi, thank you for your patch. I aplogize that it took so long for anyone to look at it. You must have a pretty old wiki to run into this issue ;)

I've submitted it for review at Gerrit change #44071

Comment 4 Alexandre Emsenhuber [IAlex] 2013-01-22 09:39:08 UTC

Change merged.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links