Last modified: 2012-10-19 13:44:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42876, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 40876 - Icon for PSD (Adobe Photoshop) file types


Summary:	Icon for PSD (Adobe Photoshop) file types

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	File management (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-10-09 05:41 UTC by Trevor Harmon
Modified:	2012-10-19 13:44 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Icon for PSD (Adobe Photoshop) file types (10.13 KB, image/png) 2012-10-09 05:41 UTC, Trevor Harmon	Details
Add an attachment (proposed patch, testcase, etc.)

Description Trevor Harmon 2012-10-09 05:41:00 UTC

Created attachment 11163 [details]
Icon for PSD (Adobe Photoshop) file types

MediaWiki lacks an icon for PSD (Adobe Photoshop) file types. I suggest the attached file be included in the MediaWiki distribution so that PSD files display an appropriate icon. It should be placed in skins/common/images/icons/fileicon-psd.png

Since it came from the same source as the other MediaWiki icons, there are no licensing issues. (See the pics/crystalsvg/cr128-mime-image.png file of kdelibs-3.4.0.)

Comment 1 Sumana Harihareswara 2012-10-12 17:20:25 UTC

Thanks, Trevor! I'm asking Ankur (drecodeam) whether he'd add this icon into the MediaWiki source tree.

Also, Trevor, if you have a patch or similar suggestion in the future, you can directly add it to our source code repository via https://www.mediawiki.org/wiki/Git/Tutorial .  Thanks!

Comment 2 drecodeam 2012-10-14 13:34:29 UTC

hey Trevor, I have added the patch for the file you mentioned, but I am not very sure about the suitability of the icon because the icon in itself does not indicate that its a Photoshop file. 
You can see the patch here : https://gerrit.wikimedia.org/r/#/c/27865/

Comment 3 Trevor Harmon 2012-10-14 13:49:27 UTC

Thanks, and I agree that the icon is not ideal. However, I don't know where to find an icon with a Photoshop logo that is under an open source license. (There may be trademark issues?) If you have any suggestions, please let me know.

Comment 4 Andre Klapper 2012-10-14 14:20:20 UTC

The similar GNOME style icon would be this one: http://git.gnome.org/browse/gnome-icon-theme/plain/gnome/256x256/mimetypes/image-x-generic.png

Would adding "PSD" on top of a generic "image" icon work, or does that create problems with regard to I18N (latin script)?

Comment 5 Trevor Harmon 2012-10-14 15:14:49 UTC

I think adding "PSD" somewhere in the icon image would be a good solution. I don't see how this would cause an I18N issue since it's embedded in the image. (But maybe I'm not understanding you.)

Comment 6 Antoine "hashar" Musso (WMF) 2012-10-19 13:44:03 UTC

Patch merged. Thanks.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links