Last modified: 2014-09-09 17:15:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42920, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40920 - Template redirects can't be used as custom licenses in UW, for example, {{PD-simple}}
Template redirects can't be used as custom licenses in UW, for example, {{PD-...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 35901 67206 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-10 11:08 UTC by Ferry Roland
Modified: 2014-09-09 17:15 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
This is the error (7.38 KB, image/png)
2012-12-01 04:07 UTC, Ferry Roland
Details

Description Ferry Roland 2012-10-10 11:08:25 UTC
Hello. I tested in my desktop when I trying to upload image that is {{PD-simple}},UploadWizard blocked it and it says is a wrong license but not. It's a license tag is valid. I try many times when I try to upload it and says wrong. I might confused to Found in internet. So,I can't do it. It not occur in Old form,which that works. Please Help!
Comment 1 Andre Klapper 2012-10-10 11:28:02 UTC
Hi Ferry, 
unfortunately this report is not very useful because it does not describe the problem well. If you have time and can still reproduce the problem, please read https://www.mediawiki.org/wiki/How_to_report_a_bug and add a more useful description to this report by providing exact steps to reproduce (click by click).
Also, which exact Mediawiki version is this about?

> I might confused to Found in internet.

I don't understand that sentence. :(
Comment 2 Sumana Harihareswara 2012-10-12 18:49:30 UTC
Andre, I think Ferry is referring to the UploadWizard license selector choices, which, if you choose "This file is not my own work", include "I found it on the Internet -- I'm not sure".  So maybe Ferry has configured the local MediaWiki instance so that it doesn't allow certain license choices, and is worried that s/he has confused one of the licenses for another.

Ferry, please do answer Andre's questions and read that page. Thanks!
Comment 3 Andre Klapper 2012-11-11 13:03:19 UTC
Ferry: Please provide steps to reproduce (click by click).
Where to you set "{{PD-simple}}"?

> UploadWizard blocked it and it says is a wrong license but not.

What is the exact and complete message that is shown?


Trying myself on http://test2.wikipedia.org/wiki/Special:UploadWizard :
Under "Release rights", I choose
* This file is not my own work.
* I found it on the Internet -- I'm not sure
  I believe this work is freely licensed or legally in the public domain. 
  I understand that if I do not add the necessary licensing information 
  in a timely fashion, the file may be deleted.
I get asked for "Source" and "Author(s)" and everything works fine.
Comment 4 Ryan Kaldari 2012-11-23 02:58:41 UTC
I see the problem (and the cause). Steps to reproduce:
1. Open Special:UploadWizard on Commons
2. Choose a file to upload
3. Click 'Continue'
4. Choose 'This file is not my own work.'
5. Enter a Source and Author
6. Choose 'Another reason not mentioned above'. (This is where you go to enter a custom license.)
7. Enter '{{PD-simple}}'
8. Click 'Continue'

The problem is that PD-simple isn't an actual template, but a redirect to PD-shape. And because of this, it isn't assigned to 'Category:PD license tags'. We need to have UploadWizard check for redirects here and follow them.
Comment 5 Ferry Roland 2012-11-30 13:49:59 UTC
Oh yeah.I'm forgot about this...
Comment 6 Ferry Roland 2012-11-30 13:53:32 UTC
I'm forgot about {{PD-shape}}. It's wrong,That FleetCommand Give me a "Keep and change to {{PD-simple}}",but that's wrong! FleetCommand Give me a wrong setence! That's right!
Comment 7 Ferry Roland 2012-12-01 04:07:50 UTC
Created attachment 11440 [details]
This is the error

This is my error,This is when i was as "DudeTwo".
Comment 8 Ferry Roland 2012-12-01 04:16:00 UTC
Become major bug again,because license redirects won't read UploadWizard properly.
Comment 9 Ferry Roland 2012-12-01 04:16:42 UTC
Become major bug again,because license redirects won't read by UploadWizard
properly.
Comment 10 Ferry Roland 2012-12-01 04:19:25 UTC
Hello all,This bug makes license redirects will not read properly by UploadWizard.This is not occur in normal upload form.
Comment 11 Ferry Roland 2012-12-01 04:24:52 UTC
Please give me a patch,please.
Comment 12 Ryan Kaldari 2012-12-14 23:29:45 UTC
The bug is already marked as High priority. Spamming the bug comments won't speed things up any.
Comment 13 Nischay Nahata 2013-02-25 17:45:01 UTC
https://gerrit.wikimedia.org/r/#/c/50755/
Comment 14 Mark Holmquist 2013-07-19 17:23:13 UTC
*** Bug 35901 has been marked as a duplicate of this bug. ***
Comment 15 Greg Grossmeier 2014-06-24 17:28:37 UTC
(In reply to Nischay Nahata from comment #13)
> https://gerrit.wikimedia.org/r/#/c/50755/

That patch is getting reviews. It is currently being -1'd by Jenkins (failing tests, needs a rebase) as of May 22nd (about a month ago).

Nischay: Are you able to continue with the work on the patch?

Gergo: Are you still working on this? I'm going to reset assignee for now but please do re-take it if you are able to work more on this.
Comment 16 Rainer Rillke @commons.wikimedia 2014-06-27 18:33:00 UTC
*** Bug 67206 has been marked as a duplicate of this bug. ***
Comment 17 Andre Klapper 2014-08-25 15:24:43 UTC
This is stuck; somebody needs to be assigned and rework the patch if this is really still "high priority".
Comment 18 Mark Holmquist 2014-09-09 17:15:01 UTC
Doesn't seem to be an issue anymore - tested on betacommons with {{blah}} which redirects to {{blah blah blah}} which is in [[Category:License tags]] - may also have been fixed because we just removed license template validation in UW.

Closing!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links