Last modified: 2014-11-02 01:03:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T42975, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 40975 - ObjectComparer::dataEquals needs more tests
ObjectComparer::dataEquals needs more tests
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
: need-unittest
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-12 10:57 UTC by Jeroen De Dauw
Modified: 2014-11-02 01:03 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jeroen De Dauw 2012-10-12 10:57:22 UTC
This is an involved method with lot's of potential for fail, yet it has no tests.
Comment 1 Lydia Pintscher 2013-10-08 16:44:15 UTC
Still the case?
Comment 2 Jeroen De Dauw 2013-10-08 18:14:21 UTC
Yes, this is now one of the highest project risks, as analysed by PHPUnit, in DataModel.
Comment 3 Marius Hoch 2014-11-01 22:11:45 UTC
ObjectComparer no longer exists within DataModel.
Comment 4 Jeroen De Dauw 2014-11-02 01:03:05 UTC
Yes - I finally managed to kill the evil thing \o/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links