Last modified: 2014-09-26 10:18:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43046, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41046 - Collection should process redirects
Collection should process redirects
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-15 20:36 UTC by T. Gries
Modified: 2014-09-26 10:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2012-10-15 20:36:59 UTC
Example:

The book https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden
was created some years ago. Now one of the articles making that book has been changed in the meantime.

Rendering the book now results in that page missing. i.e. the redirect not being processed but resulting in text (PDF and epub)

"Elbehochwasser 2002

1. WEITERLEITUNG Elbhochwasser 2002"
Comment 1 Andre Klapper 2012-10-25 00:35:51 UTC
Confirming. The created PDF includes the lines:

  Elbehochwasser 2002
  1. WEITERLEITUNG Elbhochwasser 2002

and afterwards the next article starts. No content of the "Elbehochwasser 2002" article included at all.
Comment 2 Siebrand Mazeland 2012-10-25 07:21:34 UTC
Not sure why I was put on CC, Andre. I guess that when one does some maintenance to an extension, one is regarded as the cause of all future bugs, or instantly promoted to maintainer :).

Anyway, I guess that Collection has never supported redirects, so that this behavior is unspecified. I'll leave this to the PediaPress people to confirm.

If this is indeed the case, this issue should be treated as an enhancement request along the lines of "When a redirected page is part of a book, the redirect target should be in all rendered versions".
Comment 3 T. Gries 2012-10-25 07:24:31 UTC
Siebrand:

E:Collection *must* in my view be capable to treat redirects. Users store books, and other users move articles - book collectors will not be able to follow all these "moves" in due time.

So, actually, this appears to be an enhancement bug
Comment 4 T. Gries 2012-10-25 07:25:36 UTC
reverted your recent change on my book (to keep it as a test case like described above).
Comment 5 Siebrand Mazeland 2012-10-25 07:34:41 UTC
I've updated the issue summary to be more concise. 

(In reply to comment #3)
> E:Collection *must* in my view be capable to treat redirects. Users store
> books, and other users move articles - book collectors will not be able to
> follow all these "moves" in due time.

That's a matter of view. We can hopefully agree to disagree as I don't think continuing this path is productive.

In any case, PediaPress is responsible for maintenance on the Collection extension. I'll not be participating in product management of development of new features for the extension. There are 64 other open issues on the Collection extension that may compete for the little attention it is given.

(In reply to comment #4)
> reverted your recent change on my book (to keep it as a test case like
> described above).

I think that's unwise, because as you stated, your book is now broken and the test case is very easy to reproduce.
Comment 6 T. Gries 2012-10-25 08:30:44 UTC
Hi, you are very strict... but accept your points. The book is repaired now, and I like the new big title.
Comment 7 Christoph Kepper 2012-10-25 08:55:15 UTC
Hi, we are exploring a fix that will follow redirects if no explicit revision is stored in the collection. The fix seems to be quite simple, but we need a few days to make sure that it does not produce any unwanted side effects.
Comment 8 Volker Haas 2012-10-30 11:07:24 UTC
Bug seems to be fixed with the latest changes to the Collection Extension (the original example is now working)
Comment 9 T. Gries 2012-10-30 19:30:48 UTC
Not working on https://de.wikipedia.org/wiki/Benutzer:Wikinaut/B%C3%BCcher/Dresden . 

Perhaps de-wikipedia is not yet running the current E:Collection version ?
Comment 10 Andre Klapper 2012-10-30 19:49:26 UTC
http://de.wikipedia.org/wiki/Spezial:Version states it's using Collection.
Comment 11 T. Gries 2012-10-30 19:52:32 UTC
Apparently an older version of it:

Collection (Version 1.6.1) 	(9f37005)

Fri, 21 Sep 2012 21:49:20 +0100XSelect timezone:   (20:49 +0000)
Comment 12 Marcin Cieślak 2012-10-30 19:59:16 UTC
Right, https://de.wikipedia.org/wiki/Spezial:Version says it is now 9f37005e78a068821c45d9d313394c6728f55b4a while current master is at 106fbbd39019656f99d735b9f549f8a593b0b097, which is 51 non-localization commits newer.
Comment 13 Volker Haas 2012-10-31 10:29:23 UTC
I apparently got tricked into thinking this would have been fixed, since the original saved collection was modified (and the Collection Extension contained changes that seemed to indicate a fix)...
Comment 15 T. Gries 2014-09-26 10:18:29 UTC
(In reply to Nemo from comment #14)
> https://de.wikipedia.org/w/index.php?title=Spezial:
> Buch&bookcmd=render_collection&colltitle=Benutzer:Wikinaut/B%C3%BCcher/
> Dresden&writer=rdf2latex is 488 MB... 237 pages and no WEITERLEITUNG
> anywhere, can we call this fixed by OCG/new PDF renderer or am I looking in
> the wrong place?

Currently, I cannot confirm that the bug is solved, the reason is that the book collection has been corrected NOT to make use of articles which are redirected.

So, in order to check whether the issue is solved or not, you have to construct a short book collection with at least one article which involves a REDIRECT. Then render as PDF and look, whether the REDIRECTion is actually performed by Extension:Collection, or whether the collection shows an empty page with the Text


 Elbehochwasser 2002
  1. WEITERLEITUNG Elbhochwasser 2002

I don't want to change the (working) Dresden-Buch collection, so please can I ask you to prepare a test collection for testing this issue/solution?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links