Last modified: 2014-02-26 12:09:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43063, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41063 - Oracle EZconnect, if supported, conflicts with error message
Oracle EZconnect, if supported, conflicts with error message
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.20.x
All All
: Normal major with 1 vote (vote)
: 1.21.x release
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks: oracle
  Show dependency treegraph
 
Reported: 2012-10-16 03:13 UTC by Andrew Fabbro
Modified: 2014-02-26 12:09 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andrew Fabbro 2012-10-16 03:13:07 UTC
The installer says "If you are using client libraries 10g or newer you can also use the Easy Connect naming method."

However, when attempting to do so, I encounter

"Invalid database TNS "(my info here)". Use only ASCII letters (a-z, A-Z), numbers (0-9), underscores (_) and dots (.)."

EZconnect usually uses forward slashes, which apparently is not allowed.  The EZConnect doc linked to shows many examples using forward slashes, hence my confusion.
Comment 1 Roy Olsen 2012-12-31 10:39:51 UTC
The validation code does not allow for forward slash (/), thus an Easy Connect string will never be accepted. The validation code should be changed to accept both colon and slash. (Ex. localhost/XE:POOLED).

Problem is in includes/installer/OracleInstaller.php line 90. A quick workaround is to remove line 90 and 91:

   } elseif ( !preg_match( '/^[a-zA-Z0-9_\.]+$/', $newValues['wgDBserver'] ) ) {
                        $status->fatal( 'config-invalid-db-server-oracle', $newValues['wgDBserver'] );
Comment 2 Roy Olsen 2012-12-31 11:07:47 UTC
Line numbers in my previous comment relate to version 1.20.2. Correct line number for the validation code in 1.19.2 is line 76.
Comment 3 Roy Olsen 2012-12-31 11:10:16 UTC
In other words, problem still exist in both 1.19.3 and 1.20.2 ;-)
Comment 4 Jure Kajzer 2013-05-26 07:36:07 UTC
Just commited a patch for that into review and will be backporting it as soon as it gets aprooved.
Comment 5 Andre Klapper 2014-02-26 12:09:04 UTC
Already fixed:
https://gerrit.wikimedia.org/r/#/q/Ie3a0af9801bfdbc9129298be07e1676145a1607a,n,z

For future reference, putting bug report numbers into commit messages welcome.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links