Last modified: 2014-02-12 23:47:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43091, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41091 - Images loading in dynamic sections even when images disabled
Images loading in dynamic sections even when images disabled
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-17 00:49 UTC by Arthur Richards
Modified: 2014-02-12 23:47 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arthur Richards 2012-10-17 00:49:53 UTC
The summary pretty much says it all. To replicate:
* Ensure you're in the beta for MobileFrontend
* Settings -> disable images
* Load article with sections containing images (eg Barack Obama on enwiki)
* Click a section header for a section containing images (eg Barack Obama -> Presidential campaigns)
* Note images loading :(
Comment 1 Sumana Harihareswara 2012-10-17 18:22:51 UTC
Is this happening on master?
Comment 2 Arthur Richards 2012-10-17 18:32:49 UTC
Yes, it's happening on master (and incidentally currently in production), but only on the beta version of MobileFrontend, which is expected to contain various issues such as this. But this will need to be fixed before being moved out of beta into our normal production.
Comment 3 Jon 2012-10-18 21:21:36 UTC
I guess what needs to happen is this:
* mwMobileFrontendConfig needs to pass a flag saying that images are disabled
* calls to the api to grab sections should pass a parameter (I forget what this parameter is) to request the content of sections without images

Should be relatively easy.
Comment 4 Juliusz Gonera 2012-11-28 01:58:03 UTC
Fix in https://gerrit.wikimedia.org/r/#/c/35591/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links