Last modified: 2012-10-18 11:31:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43110, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41110 - mediawiki/extensions/CreditSource.git -> mediawiki/extensions/CreditsSource.git
mediawiki/extensions/CreditSource.git -> mediawiki/extensions/CreditsSource.git
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-17 15:19 UTC by Dereckson
Modified: 2012-10-18 11:31 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dereckson 2012-10-17 15:19:55 UTC
There is a misspelling in the repository name.

Current name: mediawiki/extensions/CreditSource.git
Correct name: mediawiki/extensions/CreditsSource.git
Comment 1 Chad H. 2012-10-17 15:23:12 UTC
We cannot rename repositories.
Comment 2 Dereckson 2012-10-17 15:25:40 UTC
So what do to, delete and recreate it?

We aren't going to have in our CommonSettings.php a wrongly named extension
folder, are we?

See https://gerrit.wikimedia.org/r/#/c/28238/2/wmf-config/CommonSettings.php
Comment 3 Chad H. 2012-10-17 15:44:08 UTC
(In reply to comment #2)
> So what do to, delete and recreate it?
> 

In theory, if contributions hadn't already been made: https://gerrit.wikimedia.org/r/#/q/CreditSource,n,z

If we delete it, that will end up pointing to the wrong repo. We need a rename-project plugin from upstream.

> We aren't going to have in our CommonSettings.php a wrongly named extension
> folder, are we?
> 
> See https://gerrit.wikimedia.org/r/#/c/28238/2/wmf-config/CommonSettings.php

I don't think it's a big deal.
Comment 4 Dereckson 2012-10-17 17:24:37 UTC
What about follow https://docwhat.org/gerrit-rename-a-project/ instructions?
Comment 5 Chad H. 2012-10-17 18:05:50 UTC
Outdated info. There is no "projects" table anymore.
Comment 6 MZMcBride 2012-10-18 00:00:59 UTC
I'm not sure what's going on here.

Please create a repository named "mediawiki/extensions/CreditsSource.git" and abandon/kill off/mark as old/whatever the misspelled repo ("mediawiki/extensions/CreditSource.git").

Alternately, you could rename the extension to "CreditSource".

But the repo name really should match the extension name. Proceeding with the status quo is going to cause way more future problems than any pain of switching the repo name now, surely.
Comment 7 Chad H. 2012-10-18 01:34:23 UTC
Made a new repo.

Old one's still there (r/o, yet another "to be deleted").

All the commits need to be resubmitted.
Comment 8 Dereckson 2012-10-18 11:26:49 UTC
I cloned the new repo and pulled old repository commits, then edited .gitreview. I've the commits history above.

Could you:
- whether temporarily the right +2 Forge Committer or Tagger identity, so I can push the repo to Gerrit
- whether bypass the review system and do a git push directly? You'll find a repository tarball at http://grip.espace-win.org/~dereckson/CreditsSource.tar.gz

__________________________________________________________________________

commit 05c36f32781f2287abee59b2ce7311c676a7f8ae
Author: Dereckson <dereckson@espace-win.org>
Date:   Thu Oct 18 13:19:58 2012 +0200

    Fixing .gitreview to point to CreditsSource extension

    Change-Id: I856bed3a163221a90136712ada924a8b6e7e0a79

commit 1f443c5873b706f222faca4ae6ec2e6260b394c8
Merge: 31350f8 3aaf1cd
Author: Dereckson <dereckson@espace-win.org>
Date:   Thu Oct 18 13:10:16 2012 +0200

    Merge with the former mediawiki/extensions/CreditSource repository

    Change-Id: I568fde131f85507c25f06baf5cd14dfe799c3467

commit 31350f812890bd94e1085f812b167ac405f43696
Author: Demon <chadh@wikimedia.org>
Date:   Thu Oct 18 01:33:28 2012 +0000

    Initial empty repository

commit 3aaf1cddafdd20ba25508b80466649d7d1fa5f47
Author: Reedy <reedy@wikimedia.org>
Date:   Wed Oct 17 00:00:44 2012 +0100

    Remove duplicate code from newSimple

    Update loader location for newSimple in CreditSource_body.php

    Reformat newSimple

    Change-Id: I6492fb8290f4f87195fe79302abc553266f8c066

commit e20ade24a7ffd685e7563f56f159ef0a0711adf5
Author: csteipp <csteipp@wikimedia.org>
Date:   Tue Oct 16 11:37:59 2012 -0700

    Adding ExternalAttribution to repo

    Change-Id: Ia2277907356f6086791c4f51c00c4926ac0fb3b9

commit 422cd17792c9b4d801d15a119c5a7a64af628a49
Author: Reedy <reedy@wikimedia.org>
Date:   Fri Oct 12 16:28:06 2012 +0100

    Reformat code

    Change-Id: I9ea38f7cc66df49f5dc0314b602ea2e4c05237e8

commit 96a20b0869f168b294fa95fecf9d6dae8030a12c
Author: Reedy <reedy@wikimedia.org>
Date:   Fri Oct 12 16:27:16 2012 +0100

    Initial commit

    Change-Id: I7729c60ecb95bfee35d9b18fc6f266783aea2f8c

commit 018df60a86130ba77ca8fdbea3a6da58178e6d94
Author: Reedy <reedy@wikimedia.org>
Date:   Thu Oct 11 20:34:37 2012 +0100

    Add .gitreview and .gitignore

    Change-Id: I977d2a25059ce52d4371382e642b3dabf2c4c19a
Comment 9 Dereckson 2012-10-18 11:31:46 UTC
Sorry, I pasted the bad version of my text files (it misses some words and the relevant Gerrit right were the one from an older Gerrit version). Please read the second paragraph as is:

Could you:
- whether temporarily assign me the right "Forge committer & author identity" on the project, so I can submit the changes to the review system
- whether bypass the review system and do a git push directly? In this hypothesis, you'll find a repository tarball at http://grip.espace-win.org/~dereckson/CreditsSource.tar.gz

Thank you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links