Last modified: 2013-03-25 21:47:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43117, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41117 - VisualEditor: Offset is incorrect after alienInline in Firefox
VisualEditor: Offset is incorrect after alienInline in Firefox
Status: RESOLVED INVALID
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Inez Korczyński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-17 17:36 UTC by Christian Williams
Modified: 2013-03-25 21:47 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Williams 2012-10-17 17:36:52 UTC
If the linmod is 
ABC<alienInline></alienInline>DEF
0123            4             5678

When the cursor is at 5, getOffset returns 3. Programmatically setting selection to 5 will correctly place the cursor, but once again, getting the offset will return 3.
Comment 1 Christian Williams 2012-10-18 20:13:45 UTC
This is if aliens are contentEditable="true".
Comment 2 Roan Kattouw 2012-10-24 17:32:04 UTC
(In reply to comment #1)
> This is if aliens are contentEditable="true".
Aren't they supposed to be contentEditable="false"?
Comment 3 Inez Korczyński 2012-10-24 17:54:31 UTC
Having contentEditable="false" is the original idea but unfortunately it does not work for IE (IE does not respect contentEditable="false" inside contentEditable="true"). Now we are experimenting with having contentEditable="true" and blocking interaction with JavaScript but this approach has its downsides as well - for instance you would get a spellcheck underlines for misspelled words inside alien (majority of browsers we want to support does not respect spellcheck="false" inside spellecheck="true").
We might end up with different approaches for different browsers (of course this is not the preferred solution due to possible high costs of maintenance and testing).
Comment 4 James Forrester 2013-02-07 02:50:44 UTC
Is this still an issue, or has it been fixed through the various re-writes of this area?
Comment 5 Christian Williams 2013-03-25 21:47:54 UTC
Yeah, fixed through various re-writes. We're going to leave aliens as ce="false" for standards-based browsers and we'll have to programmatically fix IE if the cursor ends up inside.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links