Last modified: 2013-02-06 17:17:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43161, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41161 - Parsoid: Link targets and display are corrupted when removing annotations from part of the link
Parsoid: Link targets and display are corrupted when removing annotations fro...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-18 10:55 UTC by Liangent
Modified: 2013-02-06 17:17 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Liangent 2012-10-18 10:56:22 UTC
This is especially broken for the second and third case because stray characters are added.
Comment 2 Roan Kattouw 2012-12-03 21:55:18 UTC
This is a Parsoid bug.

To reproduce: paste <p><a href="Foo" rel="mw:WikiLink">foo</a></p> into http://parsoid.wmflabs.org/_html/ . This should serialize to [[foo]], or maybe [[Foo|foo]], but not [[Foo]].
Comment 3 Gabriel Wicke 2013-01-28 22:20:32 UTC
Current output is [[foo]].
Comment 4 Liangent 2013-01-29 01:38:59 UTC
(In reply to comment #3)
> Current output is [[foo]].

I assume this was fixed a while ago because you didn't specify a commit.

But this bug still exists on mw.org. See https://www.mediawiki.org/w/index.php?title=VisualEditor:LinkTrailReEditBug&diff=637012&oldid=637011

I noticed that it's impossible to select a part of a word, click "Edit link", then trash the link (the whole word is unlinked instead), but it's still possible to select some characters, then click "Clear formatting" to unlink those characters.
Comment 5 Gabriel Wicke 2013-01-29 02:32:34 UTC
It was fixed by a rework of the link serializer I did earlier this month. That code is not yet deployed on mw.org. You can verify that it is fixed in Parsoid by following Roan's instructions in comment 2. You can also do

echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse --html2wt
Comment 6 Liangent 2013-01-29 02:41:51 UTC
(In reply to comment #5)
> It was fixed by a rework of the link serializer I did earlier this month.
> That
> code is not yet deployed on mw.org. You can verify that it is fixed in
> Parsoid
> by following Roan's instructions in comment 2. You can also do
> 
> echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse
> --html2wt

OK I'll retest it on Feb 4.
Comment 7 Liangent 2013-02-06 10:32:05 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > It was fixed by a rework of the link serializer I did earlier this month.
> > That
> > code is not yet deployed on mw.org. You can verify that it is fixed in
> > Parsoid
> > by following Roan's instructions in comment 2. You can also do
> > 
> > echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse
> > --html2wt
> 
> OK I'll retest it on Feb 4.

Bug persists.

https://www.mediawiki.org/w/index.php?title=VisualEditor:LinkTrailReEditBug&diff=641685&oldid=641684
Comment 8 Gabriel Wicke 2013-02-06 17:17:24 UTC
mw.org is not running current master- it is still on the December code version. So this is to be expected. http://parsoid.wmflabs.org/ runs the latest code.

We need to work out some issues with selective serialization before we can deploy a new version to the mw.org / enwiki backend. You'll see the fix for this bug in production after that deploy.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links