Last modified: 2013-09-04 17:00:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43195, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41195 - Hardcoded cruft in SpecialBannerLoader, "magic messages"
Hardcoded cruft in SpecialBannerLoader, "magic messages"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-19 00:04 UTC by Adam Wight
Modified: 2013-09-04 17:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Adam Wight 2012-10-19 00:04:56 UTC 

    


      




        
          Comment 1
        

        
          Adam Wight

        

        
        

        
          2012-10-19 00:08:24 UTC
        
      





for example, "getNoticeField", getDailyDonationAmount, etc...

These functions were added to support specific banner messages, and do not belong here.  However, we probably do want a general facility that allows banner messages to include specific PHP files which generate text from info available only on the backend.

    


      




        
          Comment 2
        

        
          Ryan Kaldari

        

        
        

        
          2013-02-11 18:04:14 UTC
        
      





https://gerrit.wikimedia.org/r/#/c/45257/ is related to this as it would remove the need for some of the globals currently implemented in CentralNotice.

    


      




        
          Comment 3
        

        
          Matt Walker

        

        
        

        
          2013-02-11 18:16:36 UTC
        
      





I'm thinking with the concept of banner mixins (code that we download parallel to the banner and then execute before banner DOM injection) we'll be able to remove this cruft. But we're stuck with it for now until we implement them.

getDailyDonationAmount will also require us to 'fix' contribution tracking in whatever form that takes.

    


      




        
          Comment 4
        

        
          Adam Wight

        

        
        

        
          2013-09-04 17:00:16 UTC
        
      





These magic words have been reimplemented using banner mixins.  Please see http://www.mediawiki.org/wiki/Extension:CentralNotice/Banner_mixins

    



  






  


    

      

        

          
            

              Note
              You need to
              log in
              before you can comment on or make changes to this bug.
            

          		
        
 
      

  
        





        




  
  First
  Last
  Prev
  Next
    
  This bug is not in your last
    search results.







			

			
		
		
		
		
		
		
			

				
				
				
				
				

					
Navigation

					

						
					

				

				
				
				
				
				

					
Links