Last modified: 2013-04-28 20:41:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43203, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41203 - VisualEditor: Paragraph containing nowiki block does not change style unless block selected
VisualEditor: Paragraph containing nowiki block does not change style unless ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-04-29
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-19 05:19 UTC by Nicolas Raoul
Modified: 2013-04-28 20:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nicolas Raoul 2012-10-19 05:19:53 UTC
= Heading 1a =
<nowiki>[[File:VectorEditorBasic-en.png]]</nowiki>

== Heading 2aa ==

1) Put cursor at end of nowiki line
2) Select a different style
3) Problem: Style not applied

The style is applied if the line contains simple text instead.
The style is applied if selecting the whole nowiki line instead of just putting the cursor at end of line.

I guess nowiki in headers is not usual, though.
Comment 1 James Forrester 2012-10-22 17:59:19 UTC
Confirmed in FF.
Comment 2 James Forrester 2013-02-07 02:58:57 UTC
And in Chrome.
Comment 3 Inez Korczyński 2013-02-08 22:10:49 UTC
Can't reproduce. Note that it is nowiki in paragraph, not in a header.
Comment 4 Roan Kattouw 2013-03-22 21:34:09 UTC
This is a bug in newFromContentBranchConversion(), and is caused by selectNodes() returning the paragraph rather than a text node, because the selection is between the open/closing paragraph and the alien.
Comment 5 Roan Kattouw 2013-04-26 23:55:57 UTC
https://gerrit.wikimedia.org/r/#/c/61157/
Comment 6 James Forrester 2013-04-28 20:41:12 UTC
Merged and will go out in the deploy train tomorrow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links