Last modified: 2012-10-22 20:26:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43211, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41211 - [PostEdit] PostEdit doesn't work when referrer is deactivated
[PostEdit] PostEdit doesn't work when referrer is deactivated
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PostEdit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-19 09:35 UTC by Fomafix
Modified: 2012-10-22 20:26 UTC (History)
4 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fomafix 2012-10-19 09:35:13 UTC
PostEdit doesn't work when referrer is deactivated, because document.referrer returns an empty string.

In Mozilla Firefox the [[HTTP referer]] can be deactivated on about:config with
  network.http.sendRefererHeader = 0

Is it possible to indicate isPostEdit() by a cookie, a variable or something else?
Comment 1 Steven Walling 2012-10-19 19:28:42 UTC
https://gerrit.wikimedia.org/r/#/c/28703/
Comment 2 Ori Livneh 2012-10-19 19:31:49 UTC
We don't really need to check document.referrer. We did it out of paranoia, so I removed the check. But keep in mind that cookies can be disabled too, and we can't do anything in that case.
Comment 3 TMg 2012-10-19 23:43:57 UTC
Why not do both? Prefer the cookie. If the cookie is missing check the refer(r)er. If the refer(r)er is missing do nothing.
Comment 4 Ori Livneh 2012-10-20 10:17:32 UTC
The referrer by itself cannot be used to definitively detect post-edit state. It can merely complement a cookie-based approach by providing an additional sanity-check.

Closing, as fix is in merge queue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links