Last modified: 2013-04-22 16:17:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43216, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41216 - Stub tag being put in the wrong place
Stub tag being put in the wrong place
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PageCuration (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Nischay Nahata
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-19 13:50 UTC by Oliver Keyes
Modified: 2013-04-22 16:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Comment 1 Nischay Nahata 2012-12-30 07:44:01 UTC
PageTriage puts both stub and uncategorised tags at the bottom, their relative order is still dependent on the order they are added. When both are added together the order gets wrong, https://gerrit.wikimedia.org/r/#/c/41376/ tries to fix this.
Comment 2 Ryan Kaldari 2013-01-15 05:05:46 UTC
If a certain tag needs to be in a special position, this should be achieved through the 'position' parameter in the tag's definition in ext.pageTriage.defaultTagOptions.js. Relying on the order the tags is loaded is fragile and conflicts with listing the tags in alphabetical order.
Comment 3 Ryan Kaldari 2013-01-15 05:09:10 UTC
Perhaps we should have a position called 'categories', for anything category related. These tags would be added immediately before the tags that are assigned the position 'bottom' (such as {{stub}}).
Comment 4 Nischay Nahata 2013-01-15 06:06:13 UTC
(In reply to comment #3)
> These tags would be added immediately before the tags that are
> assigned the position 'bottom' (such as {{stub}}).

But, the ordering can be still wrong. If one marks stub first and then someone else marks a page as uncategorized, the page will have uncategorized at the end.
Does this bug demand that order to be fixed too? I think that would be difficult.
Comment 5 Nischay Nahata 2013-01-15 08:58:07 UTC
Fix attempt 2
https://gerrit.wikimedia.org/r/#/c/44000/
Comment 6 Ryan Kaldari 2013-01-15 18:09:15 UTC
This solution is great.
Comment 7 Ryan Kaldari 2013-01-15 18:35:19 UTC
Merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links