Last modified: 2013-01-14 21:45:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43250, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41250 - cleanupUploadStash.php is slow and bloated
cleanupUploadStash.php is slow and bloated
Status: NEW
Product: MediaWiki
Classification: Unclassified
Maintenance scripts (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-21 01:12 UTC by Sam Reed (reedy)
Modified: 2013-01-14 21:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-10-21 01:12:16 UTC
It takes ages to run.

Also, the code does quite a large select. It should be doing batch reads

		$cutoff = time() - $wgUploadStashMaxAge;
...
		$res = $dbr->select(
			'uploadstash',
			'us_key',
			'us_timestamp < ' . $dbr->addQuotes( $dbr->timestamp( $cutoff ) ),
			__METHOD__
		);
Comment 1 Sam Reed (reedy) 2012-10-21 01:36:07 UTC
It seems to like omnomnoming memory when run against commonswiki with 100,000+ to cleanup..

1461 reedy     20   0 6437m 2.7g 4056 S    1 70.4  68:19.59 php

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links