Last modified: 2014-02-12 23:48:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43290, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41290 - Title displayed for Main Page when loaded via search
Title displayed for Main Page when loaded via search
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-22 23:20 UTC by Brion Vibber
Modified: 2014-02-12 23:48 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2012-10-22 23:20:38 UTC
* go to http://test.m.wikipedia.org/
* select beta mode
* go to search box
* type 'Main Page'
* tap the result

You should get the same view as on http://test.m.wikipedia.org/ with the special-cased sections and titles. Instead you get a plain view of the page, with 'Main Page' as the title etc.

We should either get the expected special-case data back from the API when we AJAX-load it, or we should special-case the search to not AJAX-load the main page.

Probably low priority as few people will be searching the main page though.
Comment 1 Jon 2012-10-31 20:16:23 UTC
Sounds like an issue with the API
I've seen this in the app too.

Should the API return the special cased content or the entire content?
Comment 2 Jon 2012-11-30 20:32:11 UTC
OK this is also problematic when you search for Special:Watchlist or Special:MobileMenu

Ideally we should only load content dynamically from the article namespace, however currently the json returned by the api for a search gives no indication of the namespace...

Two options:
1) Limit search to just cover the article namespace? Seems a bit unfortunate that we prevent searching for special pages etc but at least this wouldn't cause any surprises (I assume here that the Main page is not in the article namespace)

2) Update api response to include indication of namespace - this would allow us to only enhance certain search results - when clicking a search we would navigate to the page rather than attempting to dynamically load

3) Disable all dynamic loading of search results - this solution sucks but might be the easiest.
Comment 3 Jon 2012-11-30 22:45:47 UTC
I've just submitted https://gerrit.wikimedia.org/r/36312 - this attempts to load the page via ajax and if it fails it resorts to loading the url instead.

My suggestion would be to make the Main Page return an error when requested via this method of the api. This is probably a good idea as the main page renders incorrectly in the app when requested in a similar fashion.
Comment 4 Jon 2012-11-30 23:37:01 UTC
CLARIFICATION:

* go to http://test.m.wikipedia.org/
* select beta mode
* go to search box
* type 'Main Page'
* tap the result

The result has the heading "Main Page" which is inconsistent to the initial page.
Comment 5 Jon 2012-12-01 00:47:14 UTC
https://gerrit.wikimedia.org/r/36334
Comment 6 Arthur Richards 2012-12-03 19:43:39 UTC
Change merged to master. The change helped with searching for 'Main Page', but the behavior in conjunction with the 'random page' feature is a little weird. If the Main Page ashn't been configured yet, it is now unclear when using 'Random' if you are on the main page as the title text is changed to 'This homepage needs to be configured'.
Comment 7 Jon 2012-12-03 19:51:46 UTC
Can you get to the main page via random? That seems rather strange..
Comment 8 Arthur Richards 2012-12-03 20:05:09 UTC
(In reply to comment #7)
> Can you get to the main page via random? That seems rather strange..

I can locally. What is strange about that?
Comment 9 Jon 2012-12-03 20:55:59 UTC
Does the main page come up as a result of clicking random? Just trying to understand the problem here.
Comment 10 Arthur Richards 2012-12-03 21:15:41 UTC
(In reply to comment #9)
> Does the main page come up as a result of clicking random? Just trying to
> understand the problem here.

It can and does for me, at least on my local instance - both on mobile and desktop views.
Comment 11 Jon 2012-12-03 22:56:01 UTC
Opened bug 42663 to capture this new issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links