Last modified: 2012-10-23 20:03:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43316, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 41316 - Null edits produce confirmation


Summary:	Null edits produce confirmation

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	PostEdit (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized minor (vote)
Target Milestone:	---
Assigned To:	Ori Livneh

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-10-23 18:04 UTC by Steven Walling
Modified:	2012-10-23 20:03 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2012-10-23 18:04:28 UTC

Currently null edits (https://en.wikipedia.org/wiki/Wikipedia:NULLEDIT#Null_edit) produce a PostEdit message. 

This is not a huge problem from the immediate perspective of a user who may have tried to edit a page, since they did technically save their edit even if nothing was changed. However, it is slightly confusing considering that null edits do not produce a new revision in the history. 

_If it's not a big pain_, we should consider detecting null edits and not show PostEdit.

Comment 1 Ori Livneh 2012-10-23 18:06:45 UTC

Not a big pain. The ArticleSaveComplete hook sets the $revision parameter to null on null edits:

http://www.mediawiki.org/wiki/Manual:Hooks/ArticleSaveComplete

I'll fix.

Comment 2 Ori Livneh 2012-10-23 20:03:26 UTC

Gerrit change #29642.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links