Last modified: 2014-01-25 17:43:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43318, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41318 - PagedTiffHandler: The uploaded file contains errors: $1
PagedTiffHandler: The uploaded file contains errors: $1
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Tony Thomas
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-23 18:12 UTC by Sam Reed (reedy)
Modified: 2014-01-25 17:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-10-23 18:12:56 UTC
'tiff_bad_file' => 'The uploaded file contains errors: $1',

$1 is not substituted

Line 62 of PagedTiffHandler_body.php
if ( !$tr->isValidTiff() ) {
				wfDebug( __METHOD__ . ": bad file\n" );
				$status->fatal( 'tiff_bad_file' );
			}

^ No error parameter passed

Line 102

$error = array( 'tiff_bad_file', PagedTiffHandler::joinMessages( $errors ) );

^ should be ok..

Line 312

return $this->doThumbError( $params, 'tiff_bad_file' );
Comment 1 Gerrit Notification Bot 2014-01-12 15:47:34 UTC
Change 107039 had a related patch set uploaded by 01tonythomas:
Gave a new error message for !isValidTiff()

https://gerrit.wikimedia.org/r/107039
Comment 2 Gerrit Notification Bot 2014-01-25 16:18:33 UTC
Change 107039 merged by jenkins-bot:
Gave a new error message for !isValidTiff()

https://gerrit.wikimedia.org/r/107039

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links