Last modified: 2012-12-06 22:28:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43395, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41395 - ULS js builders
ULS js builders
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-25 16:12 UTC by Chris Steipp
Modified: 2012-12-06 22:28 UTC (History)
12 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Steipp 2012-10-25 16:12:19 UTC
The following javascript concerns me. I haven't found a way to get xss, but it would be good to rewrite these using element creation and .append() instead of concating and .html(). Is this possible?


* ./resources/js/ext.uls.init.js

		linkClass = 'uls-prevlang-link';
		prevLangLink = '<a href="#" lang = "' +
			previousLang + '" class = "' + linkClass + '" >' +
			prevLangName + '</a>';

* ./resources/js/ext.uls.displaysettings.js

			$fontLabel.html( '<strong>'
				+ $.i18n( 'ext-uls-webfonts-select-for', $.uls.data.getAutonym( this.uiLanguage ) )
				+ '</strong>'
				+ '<div>'
				+ $.i18n( 'ext-uls-webfonts-select-for-ui-info' )
				+ '</div>'
			);

			$fontLabel.html( '<strong>'
				+ $.i18n( 'ext-uls-webfonts-select-for', $.uls.data.getAutonym( this.contentLanguage ) )
				+ '</strong>'
				+ '<div>'
				+ $.i18n( 'ext-uls-webfonts-select-for-content-info' )
				+ '</div>'
			);
Comment 2 Chris Steipp 2012-11-02 21:48:15 UTC
Those both look good. Thanks Niklas!
Comment 3 Niklas Laxström 2012-11-10 04:09:51 UTC
Both merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links