Last modified: 2013-07-04 10:33:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43445, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41445 - Round-trip sanitized attribute values as wikitext
Round-trip sanitized attribute values as wikitext
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-27 00:39 UTC by Gabriel Wicke
Modified: 2013-07-04 10:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gabriel Wicke 2012-10-27 00:39:17 UTC 
https://gerrit.wikimedia.org/r/30313 adds a mechanism to preserve the wikitext of attributes. This should be expanded to cover more attribute keys emitted in the serializer, and should also be extended to cover values. See the comment in line 293 in ext.core.LinkHandler.js for another use case.

Basically, make sure we don't round-trip to the output of tokensToString when something is not preserved as-is because it contains non-text tokens.
Comment 1 Gabriel Wicke 2013-01-16 00:51:38 UTC 
Simple test case:

echo '<div title="<!-- foo -->hello">foo</div>' | nodejs parse --wt2wt
<div title="hello">foo</div>

We currently don't shadow HTML attributes.
Comment 2 Gabriel Wicke 2013-03-19 18:16:15 UTC 
Fixed with https://gerrit.wikimedia.org/r/#/c/54491/. Thank you Jeff!
Comment 3 Andre Klapper 2013-07-04 10:33:54 UTC 
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links