Last modified: 2013-07-25 07:06:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43506, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41506 - Sitelinks are not protocol relative
Sitelinks are not protocol relative
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest normal (vote)
: ---
Assigned To: Wikidata bugs
:
: 41592 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-29 20:10 UTC by Sam Reed (reedy)
Modified: 2013-07-25 07:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2012-10-29 20:10:53 UTC
The autocomplete code tries to do requests to HTTP sites when you're on a HTTPS site.

Chrome says no:

[blocked] The page at https://www.wikidata.org/wiki/Q59 ran insecure content from http://en.wikipedia.org/w/api.php?callback=jQuery18202386506893672049_1351541237295&action=opensearch&namespace=0&suggest=&search=PHP.


<Reedy> jeblad_WMDE: I see in sites they are all http and also http in the json site_data :(
<Reedy> https://meta.wikimedia.org/w/api.php?action=sitematrix&format=json
<Reedy> I blame $wgCanonicalServer
Comment 1 Daniel Kinzler 2012-10-31 19:25:47 UTC
I have written a maintenance script that will update the sites table and optionally strip the protocols from any URLs, making them protocol relative. 

Patch for Wikibase: I1ec863c5
This needs a core patch too: I7e22cc3c

Once these patches are in, run this:

  cd extensions/Wikibase/lib/maintenance
  php populateSitesTable.php --strip-protocols

That should fix this issue.
Comment 2 Sam Reed (reedy) 2012-10-31 19:41:29 UTC
(In reply to comment #1)
> Once these patches are in, run this:
> 
>   cd extensions/Wikibase/lib/maintenance
>   php populateSitesTable.php --strip-protocols

Not on the cluster ;)

If you could do this locally (will be quicker), and then give me a dump of the table, I can import this into the wikidata database...
Comment 3 Sam Reed (reedy) 2012-11-01 02:44:34 UTC
*** Bug 41592 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links