Last modified: 2014-02-12 23:47:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43518, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41518 - Edit link shows on protected pages
Edit link shows on protected pages
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-29 23:32 UTC by Jon
Modified: 2014-02-12 23:47 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2012-10-29 23:32:10 UTC 
Visit a protected page whilst logged in.
Note that the edit link appears in the top right.
Comment 1 Jon 2012-12-03 22:59:35 UTC 
How can we check the permissions on an article? I guess we should rethink this line:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/MobileFrontend.git;a=blob;f=javascripts/common/mf-navigation.js;h=d7a8b1eabca6ff056c5b528a03d75caf4bf7dfc6;hb=HEAD#l77

so instead of requesting an edittoken to check for whether to enable editing it checks the permissions.

This will also allow us a generic method for checking article permissions (I anticipate things like photo uploads will probably need to check whether they should run or not)
Comment 2 Jon 2012-12-21 15:04:48 UTC 
https://gerrit.wikimedia.org/r/39766
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links