Last modified: 2014-02-12 23:53:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43543, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41543 - Missing indentation for lists
Missing indentation for lists
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-30 12:42 UTC by Derk-Jan Hartman
Modified: 2014-02-12 23:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: iOS 6.x
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2012-10-30 12:42:54 UTC
Due to the reset stylesheet, there is 0 indentation for list items, because padding is set to 0. This can be a tad confusing at times, especially with multi level lists.
Comment 1 Derk-Jan Hartman 2012-10-30 13:23:53 UTC
Deployed: https://en.wikipedia.org/w/index.php?title=MediaWiki%3AMobile.css&diff=520586981&oldid=520583307

to temporarily address this on en.wp
Comment 2 Jon 2012-10-30 18:03:57 UTC
Please could you remove the change to Mobile.css - if we are to change this I'd rather we did this directly in the MobileFrontend extension. Whilst it is here there is a danger that it will be copied to other wikis which won't get updated when any change propagates to core.

Playing devils advocate why do we need indents on list?
Comment 3 Jon 2012-10-30 18:05:26 UTC
Also we should limit this to lists in #content as there is a danger this will break existing interfaces.
Comment 4 Jon 2012-10-30 18:33:56 UTC
(the original rationale was to have no margin on list items due to limited space on mobile and making the most of the mobile width) - regardless this should be discussed rather than pushed on to Mobile.css - we might want to only add the margin with a media query on larger screens for example.
Comment 5 Derk-Jan Hartman 2012-10-30 20:36:04 UTC
The problem with no margin is in

ol
 li
  ol
   li

which now renders as:

*
*

instead of
*
  *
Comment 6 Jon 2012-10-30 20:40:30 UTC
Very true.
Lets add this to core.
Feel free to send a patch - otherwise I'll get one in sometime today

Less css rule would look something like this:
#content {
  ul, ol {
    ul, ol {
       margin-left: 8px;
    }
}
Comment 7 Derk-Jan Hartman 2012-10-30 21:13:44 UTC
Hmm, we also have dl.

And there is an issue on talk pages (or pages that are used as talk pages like WP:VP/T), where dl, ul and ol are expected by the editors to create initial indentation. This is an unusual usage of ul/ol/dl of course, but a very widely accepted usage throughout the wiki's.

Opening of discussion
:reply
*reply
**reply
#reply
Comment 8 Derk-Jan Hartman 2012-10-30 21:16:20 UTC
Example URL with many ol,ul,dl

http://en.m.wikipedia.org/wiki/Wikipedia:Village%20pump%20(technical)?debug=true#section_2
Comment 9 Jon 2012-10-31 18:51:27 UTC
Let's just apply https://en.wikipedia.org/w/index.php?title=MediaWiki%3AMobile.css&diff=520586981&oldid=520583307 to mf-typography.css - we can always visit this later.

Let's make sure we limit to lists in #content element however so as we do not interfere with lists in overlays, search, settings page etc...
Comment 10 Jon 2012-11-01 20:12:03 UTC
https://gerrit.wikimedia.org/r/31313 does this take care of the problem?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links