Last modified: 2012-10-30 16:54:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43544, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41544 - Diffs with long lines cause horizontal scrollbars to appear
Diffs with long lines cause horizontal scrollbars to appear
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://gerrit.wikimedia.org/r/#/c/26...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-10-30 13:02 UTC by Bartosz Dziewoński
Modified: 2012-10-30 16:54 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot – Opera (117.98 KB, image/png)
2012-10-30 13:02 UTC, Bartosz Dziewoński
Details
Screenshot – Firefox (128.17 KB, image/png)
2012-10-30 13:03 UTC, Bartosz Dziewoński
Details

Description Bartosz Dziewoński 2012-10-30 13:02:36 UTC
Created attachment 11262 [details]
Screenshot – Opera

This happens for me on Opera 12.02 and Firefox 15 on Windows XP.

gerrit appears to try to mitigate this issue by inserting <br>s into long lines, but it inserts them slightly too late, when the text is already off-screen.

I was able to work-around this for myself using two lines of CSS:
.GJEA35ODFF{ white-space: pre-wrap }
.GJEA35ODFF br{ display: none }
Comment 1 Bartosz Dziewoński 2012-10-30 13:03:08 UTC
Created attachment 11263 [details]
Screenshot – Firefox
Comment 2 Chad H. 2012-10-30 16:48:16 UTC
This is actually based on a per-user setting, and shouldn't unconditionally wrap. I spoke with upstream, and this was the consensus:

"If you wrapped all the time, you would not be able to make your screen just big enought to see either the left of the right pane only / since it would just wrap instead / not to mention that on tablets it would likely always wrap then"

Under Differences -> Preferences when viewing a patch, you can set the default column width which is where Gerrit will wrap for you. If the default is too wide, you can set it to a lower number. Marking WFM, since this is working as designed.
Comment 3 Bartosz Dziewoński 2012-10-30 16:54:56 UTC
Hm, this sounds like a pretty useless feature to me, but at least it has an explanation. Thanks.

A single checkbox for wrapping the lines to fit on screen or not would make more sense to me. I didn't expect an option like this, which is probably why I missed it.

I set column width to 999 and kept the first line of my workaround.

Thanks again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links