Last modified: 2012-12-19 15:16:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43553, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41553 - QUnit tests for DataValues fail (unless enabling wgResourceLoaderDebug)
QUnit tests for DataValues fail (unless enabling wgResourceLoaderDebug)
Status: VERIFIED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
DataValues (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-30 15:26 UTC by jeblad
Modified: 2012-12-19 15:16 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description jeblad 2012-10-30 15:26:11 UTC 
Of some reason Qunit testing of DataValues fails when $wgResourceLoaderDebug is false. A working workaround is to set it to true in LocalSettings.

Like so
$wgResourceLoaderDebug = true;
Comment 1 Jeroen De Dauw 2012-10-30 15:46:44 UTC 
Confirmed.

Exception thrown by dataValues.util: dataValues is not defined

load.p...123204Z (line 151)

ReferenceError: dataValues is not defined
Comment 2 Krinkle 2012-12-13 15:04:50 UTC 
This is most likely due to sloppy code relying on implied global variables. Make sure stuff is either tied into an established global or explicitly made global by assigning to a window property.

A simple jshint run will yield the responsible line.
Comment 3 Henning 2012-12-13 16:50:23 UTC 
Unable to reproduce. The fix submitted in https://gerrit.wikimedia.org/r/#/c/35611/ might refer to this bug.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links