Last modified: 2014-11-17 10:34:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43573, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41573 - Articles I edit do not add to my watchlist
Articles I edit do not add to my watchlist
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High normal with 5 votes (vote)
: ---
Assigned To: Wikidata bugs
: need-volunteer
: 45961 (view as bug list)
Depends on:
Blocks: 58534
  Show dependency treegraph
 
Reported: 2012-10-31 07:36 UTC by Aude
Modified: 2014-11-17 10:34 UTC (History)
15 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2012-10-31 07:36:55 UTC
Articles do not get added to the watchlist, even when "Add pages and files I edit to my watchlist" is checked in the preferences.
Comment 1 Aude 2012-10-31 08:36:57 UTC
This concerns editing items.
Comment 2 Arnav Sonara 2012-11-02 19:50:03 UTC
If articles added to watchlist manually, it works. But Preference --> Watchlist -->Add does not work.
Comment 3 jeblad 2012-11-03 10:36:57 UTC
I guess this is because we don't edit content the usual way, we do it through API calls.

Some stuff is going on at line 286 in ApiEditPage and we need to mimic it in ApiModifyEntity and other modules.
Comment 4 Amir E. Aharoni 2013-02-14 08:45:09 UTC
This is not an enhancement. It's a bug.
Comment 5 Lydia Pintscher 2013-02-18 12:13:11 UTC
I have not tried it but here's a hack that potentially helps: http://www.wikidata.org/w/index.php?title=Wikidata%3AContact_the_development_team&diff=6866598&oldid=6865573
Comment 6 Daniel Kinzler 2013-03-08 13:02:29 UTC
This should be handled by Wikidata\EditEntity (not \Wikidata\Api\EditEntity), as Wikidata\EditEntity is essentially our version of the controller login in EditPage.
Comment 7 Lydia Pintscher 2013-03-10 15:29:00 UTC
*** Bug 45961 has been marked as a duplicate of this bug. ***
Comment 8 Fomafix 2013-03-11 09:46:31 UTC
The hack in https://www.wikidata.org/wiki/MediaWiki:Common.js uses
  mw.msg( 'wikibase-save' )

Maybe the resource 'wikibase-save' not loaded when the script is executed.

This can assured by:
  mw.loader.using( 'wikibase.ui.PropertyEditTool', function () { ... } );
Comment 9 Daniel Kinzler 2013-03-19 19:14:56 UTC
Patch: I36c6a3a28 

This is still incomplete and fails unit tests; but it can already be tested, and feedback is welcome.
Comment 10 Lydia Pintscher 2013-04-07 08:43:55 UTC
Has this been fixed? Items I edit are added to my watchlist and I can't find any gadget being responsible for it.
Comment 11 Daniel Kinzler 2013-04-07 11:20:03 UTC
I do not see any code that would take care of this. I'll finish I36c6a3a28 asap.

If it's "working" on wikidata.org, it's probably some kind of JS hack (gadget or other). I would not consider that a fix.
Comment 12 T. H. Kelly (Pink&) 2013-04-07 21:31:17 UTC
(In reply to comment #11)
> If it's "working" on wikidata.org, it's probably some kind of JS hack (gadget
> or other). I would not consider that a fix.

Indeed. http://www.wikidata.org/w/index.php?title=MediaWiki%3ACommon.js&diff=7497196&oldid=5042224 is responsible; better than nothing, but far from perfect.
Comment 13 Daniel Mietchen 2013-04-08 01:00:16 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > If it's "working" on wikidata.org, it's probably some kind of JS hack (gadget
> > or other). I would not consider that a fix.
> 
> Indeed.
> http://www.wikidata.org/w/index.php?title=MediaWiki%3ACommon.
> js&diff=7497196&oldid=5042224
> is responsible; better than nothing, but far from perfect.

Doesn't work for me.
Comment 14 Daniel Kinzler 2013-04-11 11:22:29 UTC
I36c6a3a28 is waiting for review
Comment 15 Gerrit Notification Bot 2013-05-06 13:21:59 UTC
https://gerrit.wikimedia.org/r/54704 (Gerrit Change I36c6a3a285f21cc0f4a1298752b34823140cb736) | change APPROVED and MERGED [by Tobias Gritschacher]
Comment 16 Daniel Mietchen 2013-05-06 17:09:40 UTC
Still does not work for me (Chrome under OSX 10.5.8).
Comment 17 Andre Klapper 2013-05-07 09:28:02 UTC
Patch has been merged into the codebase, it's not yet deployed on the servers.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links