Last modified: 2012-11-22 08:29:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43673, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41673 - @group Database not honored with MediaWikiLangTestCase childs
@group Database not honored with MediaWikiLangTestCase childs
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-02 07:01 UTC by Jan Luca
Modified: 2012-11-22 08:29 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jan Luca 2012-11-02 07:01:00 UTC
There seems to be a bug in the Jenkins-tests because the "MediaWiki-Tests-Databaseless"-test (options: "--exclude-group Database,Broken,ParserFuzz,Stub") runs my new PHPUnit-test (gerrit:31067) though this test is in the Database-group.

The url of the Jenkins-log is https://integration.mediawiki.org/ci/job/MediaWiki-GIT-Fetching/7066/
Comment 1 Antoine "hashar" Musso (WMF) 2012-11-02 11:42:27 UTC
https://gerrit.wikimedia.org/r/#/c/31067/

Seems to me that test class extending MediaWikiLangTestCase do not honor the '@group Database'.
Comment 2 Antoine "hashar" Musso (WMF) 2012-11-02 12:27:11 UTC
The warning from the Databaseless build at https://integration.mediawiki.org/ci/job/MediaWiki-Tests-Databaseless/8564/console :

There was 1 failure:

1) Warning
The data provider specified for LogFormatterTest::testLogParamsType is invalid.DB connection error: Access denied for user 'wikiuser'@'localhost' (using password: NO) (localhost)
/var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/tests/phpunit/MediaWikiPHPUnitCommand.php:45/var/lib/jenkins/jobs/MediaWiki-GIT-Fetching/workspace/tests/phpunit/phpunit.php:107
Comment 3 Antoine "hashar" Musso (WMF) 2012-11-02 12:41:14 UTC
This is caused by the PHPUnit data provider using calls that requires a database connection. The database providers seems to be executed before filtering tests.
Comment 4 Jan Luca 2012-11-04 17:46:49 UTC
My problem I have fixed (using separate tests for each type) but I think we keep the bug open for fixing the PHPUnit-bug.
Comment 5 Antoine "hashar" Musso (WMF) 2012-11-22 08:29:47 UTC
This was caused by a dataProvider attempting to use a database connection. Since providers are run before filtering, that ends up throwing an errors when no DB is set (which is the case in Databaseless Jenkins job.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links