Last modified: 2013-10-27 17:57:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43759, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41759 - Viewing old revisions and diffs should reset "Updated since last visit" markers only to that point in page history
Viewing old revisions and diffs should reset "Updated since last visit" marke...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.21.x
All All
: Normal normal (vote)
: Future release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-04 08:38 UTC by Lejonel
Modified: 2013-10-27 17:57 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Lejonel 2012-11-04 08:38:37 UTC
On history pages for pages on your watchlist some revisions are marked "updated since my last visit". This used to be reset when you viewed the most recent revision of the page (either by visiting the page itself, or viewing the last revision using its oldid, or viewing diff with the last revision).

This has (at least at Wikimedia Commons) changed recently so that visiting old revisions and diffs not including the last revision also resets the updated markings.

I think it was better the way it was before. If you have not viewed the last revision there are still changes you have not seen. That should be marked in the history page and in your watchlist.
Comment 1 Sumana Harihareswara 2012-12-18 18:40:45 UTC
Lejonel, can you still reproduce this?

Steven and Oliver, would you agree that this is a high-priority bug?
Comment 2 Oliver Keyes 2012-12-18 18:43:52 UTC
I'd put it as normal; it's somewhat disruptive to a specific way of working, but it isn't going to break anything and that workflow is in itself relatively new and still getting established. Marking as such now.
Comment 3 Lejonel 2012-12-24 10:38:00 UTC
(In reply to comment #1)
>  can you still reproduce this?

Viewing an old revision still removes "Updated since last visit".
But viewing diffs between old revisions seems to have been fixed, it does not remove update markers.
Comment 4 Michael M. 2013-04-25 09:43:28 UTC
IMHO viewing an old revision (both as a diff and as an old version of that page) should update the markers up to that point. So currently when viewing an old version too many of these markers are removed (i.e. all), viewing a diff removes too few (i.e. none).
Comment 5 Bartosz Dziewoński 2013-09-15 17:57:35 UTC
I was going to file a bug saying that viewing old revisions (and diffs from revisions you've already seen to revisions you hadn't yet) should update the markers and I've found this. Rephrasing the bug summary a little.
Comment 6 Gerrit Notification Bot 2013-09-16 12:29:35 UTC
Change 84315 had a related patch set uploaded by Bartosz Dziewoński:
Correctly update wl_notificationtimestamp when viewing old revisions

https://gerrit.wikimedia.org/r/84315
Comment 7 Gerrit Notification Bot 2013-10-27 17:52:47 UTC
Change 84315 merged by jenkins-bot:
Correctly update wl_notificationtimestamp when viewing old revisions

https://gerrit.wikimedia.org/r/84315
Comment 8 Bartosz Dziewoński 2013-10-27 17:55:34 UTC
Hooray, merged!

The patch touched a lot of different things in the codebase, so I'm not going to backport it to 1.23 just in case it accidentally broke one of them. Adjusting milestone accordingly.
Comment 9 Bartosz Dziewoński 2013-10-27 17:56:12 UTC
(I meant to 1.22, of course.)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links