Last modified: 2012-11-08 05:41:35 UTC
Several of my recent (non-minor) edits are being marked as minor (because I don't notice that the checkbox is ticked before I hit save ...). It would appear that the checkbox seems to be pre-ticked when the previous edit I made to that page was a minor one. Doesn't seem to be pre-ticked the first time I edit a page, or when unticked on the previous edit. This makes it appear that I'm marking non-muinor edits as minor deliberately - which is not a good thing! Can someone please fix/investigate?
Most likely you checked "Mark all edits minor by default" in your preferences. If you can't find that item now try to reset your preferences ([[Special:Preferences/reset]]).
Oh! Can't someone just make it possible to reset just that one preference? I looked for it, but it wasn't there - and I certainly don't want to reset ALL my preferences! Also, it's not marking all of them as minor by default - only those ones where the previous edit was marked as minor.
(In reply to comment #2) > Oh! Can't someone just make it possible to reset just that one preference? I > looked for it, but it wasn't there - and I certainly don't want to reset ALL my > preferences! But to reset only one, you have to tell the system which preference you want to reset -- but if you can find that preference you can simply flip its setting... To help you find and confirm it: it should be located in the "Advanced options" section in "Editing" tab. > Also, it's not marking all of them as minor by default - only > those ones where the previous edit was marked as minor. Is your browser pre-filling it from previously submitted form?
On the english wikipedia that option isn't appearing in [[Special:Preferences]] for me, and it's not hidden by CSS or removed by JS. That option is appearing using the API (search for minordefault): http://en.wikipedia.org/w/api.php?action=query&meta=userinfo&uiprop=options&format=jsonfm So you probably can change it with the API: http://en.wikipedia.org/w/api.php?action=help&modules=options If some options are "hidden" ( http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do not apply at all instead of still being applied to users that changed them. Note that some edits are not allowed to be minor, like new section creation or the creation of a new page. That would explain the "randomness".
(In reply to comment #4) > On the english wikipedia that option isn't appearing in [[Special:Preferences]] > for me, and it's not hidden by CSS or removed by JS. Hmm it was turned off in bug 24313.
(In reply to comment #4) > If some options are "hidden" ( > http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do > not apply at all instead of still being applied to users that changed them. I guess this can be a valid bug. Should this bug be used to track this $wgHiddenPrefs issue, or create a new bug for it?
(In reply to comment #4) > If some options are "hidden" ( > http://www.mediawiki.org/wiki/Manual:$wgHiddenPrefs ), they should probably do > not apply at all instead of still being applied to users that changed them. They don't. See includes/User.php, every pref that is hidden is automatically reset to the default when accessed in both getOption() and getOptions(). (In reply to comment #3) > Is your browser pre-filling it from previously submitted form? This is probably what's going on here. Or else they have a user script installed that remembers the setting of the checkbox and changes it.
If the edit form has sections capable of being pre-filled by a browser, something should be put in place to prevent that from happening, ideally. It shouldn't be a pre-fillable field. Having said that, my browser doesn't pre-fill edit summaries, for example (though it does make suggestions, which I have, once or twice, inadvertently used just by not noticing that it had added bits I didn't intend to add!) I don't think I have any user scripts which would check it on some occasions but not on others.
(In reply to comment #8) > If the edit form has sections capable of being pre-filled by a browser, > something should be put in place to prevent that from happening, ideally. It > shouldn't be a pre-fillable field. Having said that, my browser doesn't > pre-fill edit summaries, for example (though it does make suggestions, which I > have, once or twice, inadvertently used just by not noticing that it had added > bits I didn't intend to add!) > > I don't think I have any user scripts which would check it on some occasions > but not on others. Can you confirm whether it's already ticked in HTML sent to you?
I'm sorry, I don't quite understand which html you're referring to, and where; could you please clarify?
(In reply to comment #10) > I'm sorry, I don't quite understand which html you're referring to, and where; > could you please clarify? Page source of the editing interface.
I haz ""minordefault":0" in the html, but (as I suspected, on the page I checked on) the minor edit box was checked. Is that helpful?
Depending on your browser, there should be a "View Source" or "View Page Source" somewhere; Google for "how to view page source in $BROWSER" for the appropriate value of $BROWSER. Somewhere in all the HTML code you see, there should be something that resembles this: <input name="wpMinoredit" type="checkbox" value="1" tabindex="3" accesskey="i" id="wpMinoredit" /> What you're looking for begins with '<input', ends with '>', and has 'name="wpMinoredit"' in the middle. If you just copy and paste that tag in here, that will answer the question.
Aha! It has <input name="wpMinoredit" type="checkbox" value="1" tabindex="3" accesskey="i" id="wpMinoredit" />, and the minor edit box is ticked (I tried the same page I tried before, on which my previous edit had been marked as minor). Aaaand ... on another page , it says <input name="wpMinoredit" type="checkbox" value="1" tabindex="3" accesskey="i" id="wpMinoredit" />, but the minor edit checkbox is NOT ticked. Hmm. So what does that mean, then?
It means that the checkbox is not being served as checked in the HTML; either your browser is pre-filling it or some JavaScript on the page is checking it. You could try removing all your user scripts and see if the problem goes away, then add them back one by one until it reappears.
I can try (bummer, though ....) removing all my user scripts. Why would a user script make it mark edits as minor ONLY on pages where the previous edit had been minor?
Because whoever wrote it thought that would be a feature?
Then unrelated to bug 24313...
Can you please tell us your user name?
ThatPeskyCommoner (enwiki)
Ah, ok, I saw that one and its contributions but got lost on Jimbo-talk muds while looking for false minor edits in vain. Then you must be using monobook and https://en.wikipedia.org/?diff=457283933&oldid=454508994 explains it, you're importing a ton of stuff for wikignomes including function Ohc_edit_summary1(){ //Add a tag to the summary box setoptions(minor='true'); //removed ",watch='false'" in response to user notification 13 Nov. 2010 setreason('[[User:Ohconfucius/script|script]]-assisted [[WP:MOS|style]] audit, incl. [[WP:MOSDATES|dates]], [[MOS:LINK]] and [[MOS:TEXT]]', 'append'); doaction('diff'); } function Ohc_edit_summary2(){ // Add a tag to the summary box setoptions(minor='true'); //removed ",watch='false'" in response to user notification 13 Nov. 2010 setreason('[[User:Ohconfucius/script|script]]-assisted [[WP:MOS|style]] audit, incl. [[WP:ENGVAR|English variants]], [[WP:MOSDATES|dates]], [[MOS:LINK]] and [[MOS:TEXT]]', 'append'); doaction('diff'); } [the latter two times, on your monobook.js and in the script you import]. You have to remove all the stuff you're unsure of/you don't need, check if there are changes to other scripts you import etc. Nothing to do here on bugzilla.
OK, many thanks for that. I shall get around to that when I have some more spare moments (and meanwhile try to remember to visually double-check the box to see if it's appropriately ticked or not!)
I've removed a ton of scripts, but it still seems to be doing it (I missed a couple this morning). Any m ore ideas?
