Last modified: 2012-11-06 03:09:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43762, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41762 - File description page not accessible inside <gallery>
File description page not accessible inside <gallery>
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
https://test2.wikipedia.org/wiki/User...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-04 11:52 UTC by Raimond Spekking
Modified: 2012-11-06 03:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (227.91 KB, image/png)
2012-11-04 11:52 UTC, Raimond Spekking
Details

Description Raimond Spekking 2012-11-04 11:52:19 UTC
Created attachment 11298 [details]
screenshot

Inside a <gallery> it is impossible to go to the file description page:

1. Click on the gallery thumbnail. TMH opens a window.
2. Click on "Menu"
3. Try to click on the title. It is a link but without any reaction 

It works well with standard [[File:foo.ogv|thumb|...]] embedding.
Comment 1 Derk-Jan Hartman 2012-11-04 13:01:03 UTC
This is due to the overlay that is set by ui.dialog
Basically this part blocks the click handling of the <a>

$(document).bind($.ui.dialog.overlay.events, function(event) {
          // stop events if the z-index of the target is < the z-index of the overlay
          // we cannot return true when we don't want to cancel the event (#3523)
          if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {
               return false;
          }
});
Comment 2 Derk-Jan Hartman 2012-11-04 13:07:43 UTC
What if we move

the div.overlay-win k-menu ui-widget-content with the controls, below the videoHolder and below the timed text, and remove the z-index from from the settings div. It will then naturally be positioned on top of the video. Which is always better than mucking about with the z-index.
Comment 3 Michael Dale 2012-11-04 16:37:10 UTC
Thanks for the pointer Derk-Jan Hartman,

Fixed in https://gerrit.wikimedia.org/r/31741

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links