Last modified: 2013-01-09 14:19:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43763, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41763 - ULS Settings not getting saved
ULS Settings not getting saved
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Santhosh Thottingal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-04 12:26 UTC by Arnav Sonara
Modified: 2013-01-09 14:19 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Arnav Sonara 2012-11-04 12:26:08 UTC
On Wikidata, if a user enables IME and selects "Gujarati Inscript" for input then after refreshing the page, the settings won't save.

User will once again have to enable IME and select the required input.
Comment 1 Santhosh Thottingal 2012-11-19 04:29:49 UTC
This was fixed in gerrit I80eddfe7
Comment 2 Amir E. Aharoni 2012-12-05 17:51:16 UTC
Reopening. For logged-in users it works within one page, but all the prefs are reset after going to another page.

It looks like the 'uls-preferences' preference cannot actually be easily saved using the current API. $wgDefaultUserOptions and $wgHiddenPrefs cannot help here, because the options API validates the option names using the Special:Prefs form, but we don't want these prefs to appear in that form.

Does anybody have clever ideas that don't involve dirty hacks and core changes?
Comment 3 Siebrand Mazeland 2012-12-05 18:40:02 UTC
(In reply to comment #2)
> $wgDefaultUserOptions and $wgHiddenPrefs cannot help
> here, because the options API validates the option names using the
> Special:Prefs form, but we don't want these prefs to appear in that form.
> 
> Does anybody have clever ideas that don't involve dirty hacks and core
> changes?

Add a hook in the options API, so you can register "API only" options in extensions. That seems to be the cleaner solution.
Comment 4 Amir E. Aharoni 2012-12-10 08:10:09 UTC
These two patches are supposed to fix it:
https://gerrit.wikimedia.org/r/#/c/37791/
https://gerrit.wikimedia.org/r/#/c/37395/
Comment 5 Amir E. Aharoni 2013-01-09 14:19:52 UTC
The patches were merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links