Last modified: 2012-11-16 17:52:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43768, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41768 - Clicking outside ULS popup should close the popup
Clicking outside ULS popup should close the popup
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Amir E. Aharoni
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-04 16:16 UTC by Jon Harald Søby
Modified: 2012-11-16 17:52 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon Harald Søby 2012-11-04 16:16:50 UTC 
Hi guys, and sorry if this has been mentioned before (I did a search but couldn't find anything relevant). I just saw the ULS live on Wikidata, and of course I love it. However, there is one small annoyance: when you click outside the area of the popup, the popup should close. This behaviour is pretty much a standard on the web by now with these in-page popups (e.g. Facebook pictures), and it is what I expect when clicking outside of its area.

Otherwise, great job guys! Bravo. :-)
Comment 1 Pau Giner 2012-11-16 09:52:11 UTC 
I agree in that this is a common assumption. In the same way, clicking on the current language indicator that appears on top should also close the selector when it is open.
Comment 2 Amir E. Aharoni 2012-11-16 17:21:14 UTC 
Fix in https://github.com/wikimedia/jquery.uls/pull/39 .
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links