Last modified: 2012-11-11 13:29:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43796, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 41796 - ORMRow should release db connections after use.
ORMRow should release db connections after use.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.21.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-05 20:32 UTC by Daniel Kinzler
Modified: 2012-11-11 13:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2012-11-05 20:32:49 UTC 
Ic9e728f8 makes ORMRow get DB connections via ORMTable::getWriteDbConnection();

When getting db connections from ORMTable, please also release them using ORMTable::releaseConntetion. This allows connections to remote wikis to be recycled for later connections (for local connections, this doesn't matter).

Without it, we may end up with one connection open per foreign wiki, instead of one per cluster/section.
Comment 2 db [inactive,noenotif] 2012-11-11 13:29:26 UTC 
(In reply to comment #1)
> https://gerrit.wikimedia.org/r/#/c/32025/

Status Merged
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links