Last modified: 2012-11-06 18:37:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43820, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41820 - iframe code always embeds File:DuckandC1951.ogg
iframe code always embeds File:DuckandC1951.ogg
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-06 13:01 UTC by Guillaume Paumier
Modified: 2012-11-06 18:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Guillaume Paumier 2012-11-06 13:01:05 UTC
The iframe code to share a video always embeds File:DuckandC1951.ogg, regardless of the video that's currently viewed.

Also, the "copy code" button doesn't actually copy anything. I'm assuming these issues are related, so I'm grouping them into this report.

== Steps to reproduce ==

* Go to https://en.wikipedia.org/wiki/User:RobLa-WMF/Video_testing
* Click the "Share" icon on any video
* Click "Copy code"

== Actual results ==

1. Nothing is copied to the clipboard
2. The iframe code that is displayed contains another video:
<iframe src="//en.wikipedia.org/wiki/File:DuckandC1951.ogg?embedplayer=yes" width="1024" height="768" frameborder="0" ></iframe>

== Expected results ==

1. The iframe code is copied to the clipboard.
2. The iframe code contains the right video, not DuckandC1951.ogg.

== Additional information ==

Firefox 16.0.2 on openSUSE 12.2
Comment 1 Michael Dale 2012-11-06 16:58:54 UTC
Was related to jQuery scope issue. Also added support to always use commons as the iframe embed host ( instead of the local wiki ) if the asset is coming from commons. 

https://gerrit.wikimedia.org/r/32056

The copy to clipboard is a browser limitation. Flash supports clipboard access. We can add in flash zeroclipboard: http://code.google.com/p/zeroclipboard/ to support copy ... or just update the button to say "select embed code".
Comment 2 Michael Dale 2012-11-06 18:37:32 UTC
marked resolved 32056 has been merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links