Last modified: 2012-12-13 19:51:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T43840, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 41840 - Can't edit anything on the item when [edit] links in preferences turned off
Can't edit anything on the item when [edit] links in preferences turned off
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
: accessibility
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-11-07 01:00 UTC by Danny B.
Modified: 2012-12-13 19:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
[edit] links turned off in Preferences -> no edit possibility of the item (44.60 KB, image/png)
2012-11-07 01:00 UTC, Danny B.
Details

Description Danny B. 2012-11-07 01:00:06 UTC
Created attachment 11322 [details]
[edit] links turned off in Preferences -> no edit possibility of the item

Can't edit anything on the item when [edit] links in preferences turned off.

Even though I have right-click-edit enabled, that does not help.
Comment 1 Danny B. 2012-11-07 01:14:58 UTC
For the time being, a temporary hack in the form of

.ns-0 td.editsection { display: table-cell; }
.ns-0 span.editsection { display: inline; }

could be applied, but it's just a temporary hack.

1) .editsection should never be table cell, it actually should have always the same structure - there are bunch of scripts working with it
2) .editsection should never contain both edit and remove (and save and cancel) links since they are not *edit*
3) .editsection preferably should not be used for these links at all (especially for this particular preferences set reason, especially when there is no way for right-click-edit), suggesting .editpart/.edititem or whatever for the interwiki item and .editlabel .editdescription for label and description
Comment 2 Marius Hoch 2012-11-07 02:37:11 UTC
I've moved that hack based on the code by Danny B. into the Common.css https://www.wikidata.org/w/index.php?diff=349506&oldid=342711 So this bug is no longer reproducible/ occurring on wikidata.org...

This is only a dirty workaround, so we really should get this fixed somehow (maybe just remove the class 'editsection' from the links in the wikibase NS?)
Comment 3 Danny B. 2012-11-22 01:04:33 UTC
Reopening - no link to Git diff/patch, no info about merging etc.
Comment 4 Henning 2012-11-22 09:13:00 UTC
https://gerrit.wikimedia.org/r/#/c/33575/
Comment 5 Anja Jentzsch 2012-12-13 19:51:22 UTC
Change I0169fc5c: (bug 41840) Rename editsection css class to wb-editsection.
Change merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links